1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.schema;
import com.yahoo.collections.Pair;
import com.yahoo.config.application.api.DeployLogger;
import com.yahoo.config.model.application.provider.MockFileRegistry;
import com.yahoo.config.model.deploy.TestProperties;
import com.yahoo.config.model.test.MockApplicationPackage;
import com.yahoo.search.query.profile.QueryProfileRegistry;
import com.yahoo.schema.derived.AttributeFields;
import com.yahoo.schema.derived.RawRankProfile;
import com.yahoo.schema.parser.ParseException;
import ai.vespa.rankingexpression.importer.configmodelview.ImportedMlModels;
import org.junit.jupiter.api.Test;
import java.util.ArrayList;
import java.util.Optional;
import java.util.logging.Level;
import static org.junit.jupiter.api.Assertions.*;
/**
* @author bratseth
*/
public class RankingExpressionInliningTestCase extends AbstractSchemaTestCase {
@Test
void testFunctionInliningPreserveArithmeticOrdering() throws ParseException {
RankProfileRegistry rankProfileRegistry = new RankProfileRegistry();
ApplicationBuilder builder = new ApplicationBuilder(rankProfileRegistry);
builder.addSchema(
"search test {\n" +
" document test { \n" +
" field a type double { \n" +
" indexing: attribute \n" +
" }\n" +
" field b type double { \n" +
" indexing: attribute \n" +
" }\n" +
" }\n" +
" \n" +
" rank-profile parent {\n" +
" constants {\n" +
" p1: 7 \n" +
" p2: 0 \n" +
" }\n" +
" first-phase {\n" +
" expression: p1 * add\n" +
" }\n" +
" function inline add() {\n" +
" expression: 3 + attribute(a) + attribute(b) * mul3\n" +
" }\n" +
" function inline mul3() {\n" +
" expression: attribute(a) * 3 + singleif\n" +
" }\n" +
" function inline singleif() {\n" +
" expression: if (p1 < attribute(a), 1, 2) == 0\n" +
" }\n" +
" }\n" +
" rank-profile child inherits parent {\n" +
" function inline add() {\n" +
" expression: 9 + attribute(a)\n" +
" }\n" +
" }\n" +
"\n" +
"}\n");
builder.build(true);
Schema s = builder.getSchema();
RankProfile parent = rankProfileRegistry.get(s, "parent").compile(new QueryProfileRegistry(), new ImportedMlModels());
assertEquals("7.0 * (3 + attribute(a) + attribute(b) * (attribute(a) * 3 + if (7.0 < attribute(a), 1, 2) == 0))",
parent.getFirstPhaseRanking().getRoot().toString());
RankProfile child = rankProfileRegistry.get(s, "child").compile(new QueryProfileRegistry(), new ImportedMlModels());
assertEquals("7.0 * (9 + attribute(a))",
child.getFirstPhaseRanking().getRoot().toString());
}
@Test
void testConstants() throws ParseException {
RankProfileRegistry rankProfileRegistry = new RankProfileRegistry();
ApplicationBuilder builder = new ApplicationBuilder(rankProfileRegistry);
builder.addSchema(
"search test {\n" +
" document test { \n" +
" field a type string { \n" +
" indexing: index \n" +
" }\n" +
" }\n" +
" \n" +
" rank-profile parent {\n" +
" constants {\n" +
" p1: 7 \n" +
" p2: 0 \n" +
" }\n" +
" first-phase {\n" +
" expression: p1 + foo\n" +
" }\n" +
" second-phase {\n" +
" expression: p2 * foo\n" +
" }\n" +
" function inline foo() {\n" +
" expression: 3 + p1 + p2\n" +
" }\n" +
" }\n" +
" rank-profile child inherits parent {\n" +
" first-phase {\n" +
" expression: p1 + foo + baz + bar + arg(4.0)\n" +
" }\n" +
" constants {\n" +
" p2: 2.0 \n" +
" }\n" +
" function bar() {\n" +
" expression: p2*p1\n" +
" }\n" +
" function inline baz() {\n" +
" expression: p2+p1+boz\n" +
" }\n" +
" function inline boz() {\n" +
" expression: 3.0\n" +
" }\n" +
" function inline arg(a1) {\n" +
" expression: a1*2\n" +
" }\n" +
" }\n" +
"\n" +
"}\n");
builder.build(true);
Schema s = builder.getSchema();
RankProfile parent = rankProfileRegistry.get(s, "parent").compile(new QueryProfileRegistry(), new ImportedMlModels());
assertEquals("17.0", parent.getFirstPhaseRanking().getRoot().toString());
assertEquals("0.0", parent.getSecondPhaseRanking().getRoot().toString());
assertEquals("10.0", getRankingExpression("foo", parent, s));
assertEquals("17.0", getRankingExpression("firstphase", parent, s));
assertEquals("0.0", getRankingExpression("secondphase", parent, s));
RankProfile child = rankProfileRegistry.get(s, "child").compile(new QueryProfileRegistry(), new ImportedMlModels());
assertEquals("31.0 + bar + arg(4.0)", child.getFirstPhaseRanking().getRoot().toString());
assertEquals("24.0", child.getSecondPhaseRanking().getRoot().toString());
assertEquals("12.0", getRankingExpression("foo", child, s));
assertEquals("12.0", getRankingExpression("baz", child, s));
assertEquals("3.0", getRankingExpression("boz", child, s));
assertEquals("14.0", getRankingExpression("bar", child, s));
assertEquals("a1 * 2", getRankingExpression("arg", child, s));
assertEquals("31.0 + rankingExpression(bar) + rankingExpression(arg@)", getRankingExpression("firstphase", child, s));
assertEquals("24.0", getRankingExpression("secondphase", child, s));
}
@Test
void testNonTopLevelInlining() throws ParseException {
RankProfileRegistry rankProfileRegistry = new RankProfileRegistry();
ApplicationBuilder builder = new ApplicationBuilder(rankProfileRegistry);
builder.addSchema(
"search test {\n" +
" document test { \n" +
" field a type double { \n" +
" indexing: attribute \n" +
" }\n" +
" field b type double { \n" +
" indexing: attribute \n" +
" }\n" +
" }\n" +
" \n" +
" rank-profile test {\n" +
" first-phase {\n" +
" expression: A + C - D\n" +
" }\n" +
" function inline D() {\n" +
" expression: B + 1\n" +
" }\n" +
" function C() {\n" +
" expression: A + B\n" +
" }\n" +
" function inline B() {\n" +
" expression: attribute(b)\n" +
" }\n" +
" function inline A() {\n" +
" expression: attribute(a)\n" +
" }\n" +
" }\n" +
"\n" +
"}\n");
builder.build(true);
Schema s = builder.getSchema();
RankProfile test = rankProfileRegistry.get(s, "test").compile(new QueryProfileRegistry(), new ImportedMlModels());
assertEquals("attribute(a) + C - (attribute(b) + 1)", test.getFirstPhaseRanking().getRoot().toString());
assertEquals("attribute(a) + attribute(b)", getRankingExpression("C", test, s));
assertEquals("attribute(b) + 1", getRankingExpression("D", test, s));
}
@Test
void testFunctionRedefinitionIsIllegal() throws ParseException {
try {
RankProfileRegistry rankProfileRegistry = new RankProfileRegistry();
MockDeployLogger deployLogger = new MockDeployLogger();
ApplicationBuilder builder = new ApplicationBuilder(MockApplicationPackage.createEmpty(),
new MockFileRegistry(),
deployLogger,
new TestProperties(),
rankProfileRegistry,
new QueryProfileRegistry());
builder.addSchema(
"search test {\n" +
" document test { }\n" +
" rank-profile test {\n" +
" first-phase {\n" +
" expression: foo\n" +
" }\n" +
" function foo(x) {\n" +
" expression: x + x\n" +
" }\n" +
" function inline foo() {\n" +
" expression: foo(2)\n" +
" }\n" +
" }\n" +
"}\n");
builder.build(true);
fail("Expected failure");
}
catch (IllegalArgumentException e) {
// success
assertEquals("Function 'foo' is defined twice in rank profile 'test'", e.getMessage());
}
}
/**
* Expression evaluation has no stack so function arguments are bound at config time creating a separate version of
* each function for each binding, using hashes to name the bound variants of the function.
* This method censors those hashes for string comparison.
*/
private String censorBindingHash(String s) {
StringBuilder b = new StringBuilder();
boolean areInHash = false;
for (int i = 0; i < s.length() ; i++) {
char current = s.charAt(i);
if ( ! Character.isLetterOrDigit(current)) // end of hash
areInHash = false;
if ( ! areInHash)
b.append(current);
if (current == '@') // start of hash
areInHash = true;
}
return b.toString();
}
private String getRankingExpression(String name, RankProfile rankProfile, Schema schema) {
Optional<String> rankExpression =
new RawRankProfile(rankProfile, new LargeRankExpressions(new MockFileRegistry()), new QueryProfileRegistry(), new ImportedMlModels(), new AttributeFields(schema), new TestProperties())
.configProperties()
.stream()
.filter(r -> r.getFirst().equals("rankingExpression(" + name + ").rankingScript"))
.map(Pair::getSecond)
.findFirst();
assertTrue(rankExpression.isPresent());
return censorBindingHash(rankExpression.get());
}
private static class MockDeployLogger implements DeployLogger {
private final ArrayList<String> msgs = new ArrayList<>();
@Override
public void log(Level level, String message) {
msgs.add(message);
}
public boolean contains(String expected) {
return msgs.stream().anyMatch(msg -> msg.equals(expected));
}
}
}
|
