1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.model.application.validation;
import com.yahoo.config.application.api.ApplicationPackage;
import com.yahoo.config.model.NullConfigModelRegistry;
import com.yahoo.config.model.deploy.DeployState;
import com.yahoo.config.model.deploy.TestProperties;
import com.yahoo.config.model.test.MockApplicationPackage;
import com.yahoo.config.provision.Zone;
import com.yahoo.vespa.model.VespaModel;
import org.junit.Test;
import org.xml.sax.SAXException;
import java.io.IOException;
import java.time.Instant;
import java.time.LocalDate;
import java.time.ZoneOffset;
import java.time.format.DateTimeFormatter;
import static com.yahoo.config.model.test.TestUtil.joinLines;
import static com.yahoo.config.provision.Environment.prod;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
/**
* @author gjoranv
*/
public abstract class AccessControlValidatorTestBase {
protected Validator validator;
protected Zone zone;
private static String servicesXml(boolean addHandler, boolean protection) {
return joinLines("<services version='1.0'>",
" <container id='default' version='1.0'>",
addHandler ? httpHandlerXml : "",
" <http>",
" <filtering>",
" <access-control domain='foo' read='" + protection + "' write='" + protection + "' />",
" </filtering>",
" </http>",
" </container>",
"</services>");
}
private static final String httpHandlerXml =
joinLines(" <handler id='foo'>",
" <binding>http://foo/bar</binding>",
" </handler>");
@Test
public void cluster_with_protection_passes_validation() throws IOException, SAXException {
DeployState deployState = deployState(servicesXml(true, true));
VespaModel model = new VespaModel(new NullConfigModelRegistry(), deployState);
validator.validate(model, deployState);
}
@Test
public void cluster_with_no_handlers_passes_validation_without_protection() throws IOException, SAXException{
DeployState deployState = deployState(servicesXml(false, false));
VespaModel model = new VespaModel(new NullConfigModelRegistry(), deployState);
validator.validate(model, deployState);
}
@Test
public void cluster_without_custom_components_passes_validation_without_protection() throws IOException, SAXException{
String servicesXml = joinLines("<services version='1.0'>",
" <container id='default' version='1.0' />",
"</services>");
DeployState deployState = deployState(servicesXml);
VespaModel model = new VespaModel(new NullConfigModelRegistry(), deployState);
validator.validate(model, deployState);
}
@Test
public void cluster_with_handler_fails_validation_without_protection() throws IOException, SAXException{
DeployState deployState = deployState(servicesXml(true, false));
VespaModel model = new VespaModel(new NullConfigModelRegistry(), deployState);
try {
validator.validate(model, deployState);
fail();
} catch (IllegalArgumentException e) {
assertTrue(e.getMessage().contains("Access-control must be enabled"));
assertTrue(e.getMessage().contains("production zones: [default]"));
}
}
@Test
public void no_http_element_has_same_effect_as_no_write_protection() throws IOException, SAXException{
String servicesXml = joinLines("<services version='1.0'>",
" <container id='default' version='1.0'>",
httpHandlerXml,
" </container>",
"</services>");
DeployState deployState = deployState(servicesXml);
VespaModel model = new VespaModel(new NullConfigModelRegistry(), deployState);
try {
validator.validate(model, deployState);
fail();
} catch (IllegalArgumentException e) {
assertTrue(e.getMessage().contains("Access-control must be enabled"));
assertTrue(e.getMessage().contains("production zones: [default]"));
}
}
@Test
public void cluster_with_mbus_handler_passes_validation_without_write_protection() throws IOException, SAXException{
String servicesXml = joinLines("<services version='1.0'>",
" <container id='default' version='1.0'>",
" <handler id='foo'>",
" <binding>mbus://*/foo</binding>",
" </handler>",
" </container>",
"</services>");
DeployState deployState = deployState(servicesXml);
VespaModel model = new VespaModel(new NullConfigModelRegistry(), deployState);
validator.validate(model, deployState);
}
@Test
public void write_protection_is_not_required_for_non_default_application_type() throws IOException, SAXException{
String servicesXml = joinLines("<services version='1.0' application-type='hosted-infrastructure'>",
" <container id='default' version='1.0'>",
httpHandlerXml,
" </container>",
"</services>");
DeployState deployState = deployState(servicesXml);
VespaModel model = new VespaModel(new NullConfigModelRegistry(), deployState);
validator.validate(model, deployState);
}
@Test
public void write_protection_is_not_required_with_validation_override() throws IOException, SAXException{
DeployState deployState = deployState(servicesXml(true, false),
"<validation-overrides><allow until='2000-01-30'>access-control</allow></validation-overrides>",
LocalDate.parse("2000-01-01", DateTimeFormatter.ISO_DATE).atStartOfDay().atZone(ZoneOffset.UTC).toInstant());
VespaModel model = new VespaModel(new NullConfigModelRegistry(), deployState);
validator.validate(model, deployState);
}
private DeployState deployState(String servicesXml) {
return deployState(servicesXml, "<validation-overrides></validation-overrides>", Instant.now());
}
private DeployState deployState(String servicesXml, String validationOverrides, Instant now) {
ApplicationPackage app = new MockApplicationPackage.Builder()
.withServices(servicesXml)
.withValidationOverrides(validationOverrides)
.build();
DeployState.Builder builder = new DeployState.Builder()
.applicationPackage(app)
.zone(zone)
.properties(new TestProperties().setHostedVespa(true))
.now(now);
final DeployState deployState = builder.build();
assertTrue("Test must emulate a hosted deployment.", deployState.isHosted());
assertEquals("Test must emulate a prod environment.", prod, deployState.zone().environment());
return deployState;
}
}
|
