1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
|
// Copyright Vespa.ai. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.model.builder.xml.dom;
import com.yahoo.config.provision.NodeResources.Architecture;
import com.yahoo.config.provision.NodeResources.DiskSpeed;
import com.yahoo.config.provision.NodeResources.StorageType;
import com.yahoo.text.XML;
import org.junit.jupiter.api.Test;
import org.w3c.dom.Document;
import com.yahoo.component.Version;
import java.util.Optional;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
/**
* @author bratseth
*/
public class NodesSpecificationTest {
@Test
void validResources() {
var spec = nodesSpecification("""
<nodes count='3'>
<resources vcpu='2'
memory='3Y'
disk='4tB'
bandwidth='1ZbPs'
disk-speed='fast'
storage-type='local'
architecture='x86_64'>
<gpu count='1g' memory='3' />
</resources>
</nodes>
""");
assertEquals(3, spec.minResources().nodes());
assertEquals(3, spec.maxResources().nodes());
assertEquals(2, spec.minResources().nodeResources().vcpu(), 1e-9);
assertEquals(2, spec.maxResources().nodeResources().vcpu(), 1e-9);
assertEquals(3e15, spec.minResources().nodeResources().memoryGb(), 1e-9);
assertEquals(3e15, spec.maxResources().nodeResources().memoryGb(), 1e-9);
assertEquals(4e3, spec.minResources().nodeResources().diskGb(), 1e-9);
assertEquals(4e3, spec.maxResources().nodeResources().diskGb(), 1e-9);
assertEquals(1e12, spec.minResources().nodeResources().bandwidthGbps(), 1e-9);
assertEquals(1e12, spec.maxResources().nodeResources().bandwidthGbps(), 1e-9);
assertEquals(1 << 30, spec.minResources().nodeResources().gpuResources().count());
assertEquals(1 << 30, spec.maxResources().nodeResources().gpuResources().count());
assertEquals(3e-9, spec.minResources().nodeResources().gpuResources().memoryGb(), 1e-12);
assertEquals(3e-9, spec.maxResources().nodeResources().gpuResources().memoryGb(), 1e-12);
assertEquals(DiskSpeed.fast, spec.minResources().nodeResources().diskSpeed());
assertEquals(DiskSpeed.fast, spec.maxResources().nodeResources().diskSpeed());
assertEquals(StorageType.local, spec.minResources().nodeResources().storageType());
assertEquals(StorageType.local, spec.maxResources().nodeResources().storageType());
assertEquals(Architecture.x86_64, spec.minResources().nodeResources().architecture());
assertEquals(Architecture.x86_64, spec.maxResources().nodeResources().architecture());
}
@Test
void invalidResources() {
assertThrows(IllegalArgumentException.class,
() -> nodesSpecification("<nodes><resources vcpu='-1' /></nodes>"));
assertThrows(IllegalArgumentException.class,
() -> nodesSpecification("<nodes><resources vcpu='' /></nodes>"));
assertThrows(IllegalArgumentException.class,
() -> nodesSpecification("<nodes><resources memory='-1' /></nodes>"));
assertThrows(IllegalArgumentException.class,
() -> nodesSpecification("<nodes><resources memory='1x' /></nodes>"));
assertThrows(IllegalArgumentException.class,
() -> nodesSpecification("<nodes><resources memory='' /></nodes>"));
assertThrows(IllegalArgumentException.class,
() -> nodesSpecification("<nodes><resources vcpu='[-1,]' /></nodes>"));
assertThrows(IllegalArgumentException.class,
() -> nodesSpecification("<nodes><resources vcpu='[1,0.5]' /></nodes>"));
assertThrows(IllegalArgumentException.class,
() -> nodesSpecification("<nodes><resources memory='[,-1b]' /></nodes>"));
assertThrows(IllegalArgumentException.class,
() -> nodesSpecification("<nodes><resources memory='[1mb,999kb]' /></nodes>"));
assertThrows(IllegalArgumentException.class,
() -> nodesSpecification("<nodes><resources memory='b' /></nodes>"));
assertThrows(IllegalArgumentException.class,
() -> nodesSpecification("<nodes><resources memory='Yb' /></nodes>"));
}
@Test
void noExplicitGroupLimits() {
var spec = nodesSpecification("<nodes count='30'/>");
assertEquals(30, spec.minResources().nodes());
assertEquals( 1, spec.minResources().groups());
assertEquals(30, spec.maxResources().nodes());
assertEquals( 1, spec.maxResources().groups()); // no grouping by default -> implicit max groups is 1
assertTrue(spec.groupSize().from().isEmpty());
assertTrue(spec.groupSize().to().isEmpty());
}
@Test
void testGroupSize1() {
var spec = nodesSpecification("<nodes count='30' group-size='1'/>");
assertEquals(30, spec.minResources().nodes());
assertEquals(30, spec.minResources().groups());
assertEquals(30, spec.maxResources().nodes());
assertEquals(30, spec.maxResources().groups());
assertEquals(1, spec.groupSize().from().getAsInt());
assertEquals(1, spec.groupSize().to().getAsInt());
}
@Test
void testGroupSize3() {
var spec = nodesSpecification("<nodes count='30' group-size='3'/>");
assertEquals(30, spec.minResources().nodes());
assertEquals(10, spec.minResources().groups());
assertEquals(30, spec.maxResources().nodes());
assertEquals(10, spec.maxResources().groups());
assertEquals( 3, spec.groupSize().from().getAsInt());
assertEquals( 3, spec.groupSize().to().getAsInt());
}
@Test
void testVariableGroupSize1() {
var spec = nodesSpecification("<nodes count='30' group-size='[15, 30]'/>");
assertEquals(30, spec.minResources().nodes());
assertEquals( 1, spec.minResources().groups());
assertEquals(30, spec.maxResources().nodes());
assertEquals( 2, spec.maxResources().groups());
assertEquals(15, spec.groupSize().from().getAsInt());
assertEquals(30, spec.groupSize().to().getAsInt());
}
@Test
void testVariableGroupSize2() {
var spec = nodesSpecification("<nodes count='30' group-size='[6, 10]'/>");
assertEquals(30, spec.minResources().nodes());
assertEquals( 3, spec.minResources().groups());
assertEquals(30, spec.maxResources().nodes());
assertEquals( 5, spec.maxResources().groups());
assertEquals( 6, spec.groupSize().from().getAsInt());
assertEquals(10, spec.groupSize().to().getAsInt());
}
@Test
void testGroupSizeLowerBound() {
var spec = nodesSpecification("<nodes count='30' group-size='[6, ]'/>");
assertEquals(30, spec.minResources().nodes());
assertEquals( 1, spec.minResources().groups());
assertEquals(30, spec.maxResources().nodes());
assertEquals( 5, spec.maxResources().groups());
assertEquals( 6, spec.groupSize().from().getAsInt());
assertTrue(spec.groupSize().to().isEmpty());
}
@Test
void testGroupSizeUpperBound() {
var spec = nodesSpecification("<nodes count='30' group-size='[, 10]'/>");
assertEquals(30, spec.minResources().nodes());
assertEquals( 3, spec.minResources().groups());
assertEquals(30, spec.maxResources().nodes());
assertEquals( 30, spec.maxResources().groups());
assertTrue(spec.groupSize().from().isEmpty());
assertEquals(10, spec.groupSize().to().getAsInt());
}
private NodesSpecification nodesSpecification(String nodesElement) {
Document nodesXml = XML.getDocument(nodesElement);
return NodesSpecification.create(false, false, Version.emptyVersion,
new ModelElement(nodesXml.getDocumentElement()),
Optional.empty(), Optional.empty());
}
}
|
