1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.hosted.controller.restapi.controller;
import com.yahoo.application.container.handler.Request;
import com.yahoo.config.provision.ApplicationId;
import com.yahoo.config.provision.NodeResources;
import com.yahoo.config.provision.zone.ZoneId;
import com.yahoo.container.jdisc.HttpRequest;
import com.yahoo.test.ManualClock;
import com.yahoo.vespa.flags.InMemoryFlagSource;
import com.yahoo.vespa.flags.PermanentFlags;
import com.yahoo.vespa.hosted.controller.api.identifiers.DeploymentId;
import com.yahoo.vespa.hosted.controller.api.integration.athenz.MockAccessControlService;
import com.yahoo.vespa.hosted.controller.api.integration.configserver.Application;
import com.yahoo.vespa.hosted.controller.api.integration.resource.ResourceSnapshot;
import com.yahoo.vespa.hosted.controller.auditlog.AuditLogger;
import com.yahoo.vespa.hosted.controller.integration.NodeRepositoryMock;
import com.yahoo.vespa.hosted.controller.restapi.ContainerTester;
import com.yahoo.vespa.hosted.controller.restapi.ControllerContainerTest;
import org.junit.Before;
import org.junit.Test;
import java.io.ByteArrayInputStream;
import java.io.File;
import java.nio.charset.StandardCharsets;
import java.time.Duration;
import java.time.Instant;
import java.util.List;
import static org.junit.Assert.assertFalse;
/**
* @author bratseth
*/
public class ControllerApiTest extends ControllerContainerTest {
private static final String responseFiles = "src/test/java/com/yahoo/vespa/hosted/controller/restapi/controller/responses/";
private ContainerTester tester;
@Before
public void before() {
tester = new ContainerTester(container, responseFiles);
}
@Test
public void testControllerApi() {
tester.assertResponse(authenticatedRequest("http://localhost:8080/controller/v1/", "", Request.Method.GET), new File("root.json"));
((InMemoryFlagSource) tester.controller().flagSource()).withListFlag(PermanentFlags.INACTIVE_MAINTENANCE_JOBS.id(), List.of("DeploymentExpirer"), String.class);
// GET a list of all maintenance jobs
tester.assertResponse(authenticatedRequest("http://localhost:8080/controller/v1/maintenance/", "", Request.Method.GET),
new File("maintenance.json"));
}
@Test
public void testStats() {
var mock = (NodeRepositoryMock)tester.controller().serviceRegistry().configServer().nodeRepository();
mock.putApplication(ZoneId.from("prod", "us-west-1"),
new Application(ApplicationId.fromFullString("t1.a1.i1"), List.of()));
mock.putApplication(ZoneId.from("prod", "us-west-1"),
new Application(ApplicationId.fromFullString("t2.a2.i2"), List.of()));
mock.putApplication(ZoneId.from("prod", "us-east-3"),
new Application(ApplicationId.fromFullString("t1.a1.i1"), List.of()));
tester.assertResponse(authenticatedRequest("http://localhost:8080/controller/v1/stats", "", Request.Method.GET),
new File("stats.json"));
}
@Test
public void testUpgraderApi() {
// Get current configuration
tester.assertResponse(authenticatedRequest("http://localhost:8080/controller/v1/jobs/upgrader", "", Request.Method.GET),
"{\"upgradesPerMinute\":0.125,\"confidenceOverrides\":[]}",
200);
// Set invalid configuration
tester.assertResponse(
operatorRequest("http://localhost:8080/controller/v1/jobs/upgrader", "{\"upgradesPerMinute\":-1}", Request.Method.PATCH),
"{\"error-code\":\"BAD_REQUEST\",\"message\":\"Upgrades per minute must be >= 0, got -1.0\"}",
400);
// Ignores unrecognized field
tester.assertResponse(
operatorRequest("http://localhost:8080/controller/v1/jobs/upgrader", "{\"foo\":\"bar\"}", Request.Method.PATCH),
"{\"error-code\":\"BAD_REQUEST\",\"message\":\"No such modifiable field(s)\"}",
400);
// Set upgrades per minute
tester.assertResponse(
operatorRequest("http://localhost:8080/controller/v1/jobs/upgrader", "{\"upgradesPerMinute\":42.0}", Request.Method.PATCH),
"{\"upgradesPerMinute\":42.0,\"confidenceOverrides\":[]}",
200);
// Set target major version
tester.assertResponse(
operatorRequest("http://localhost:8080/controller/v1/jobs/upgrader", "{\"targetMajorVersion\":6}", Request.Method.PATCH),
"{\"upgradesPerMinute\":42.0,\"targetMajorVersion\":6,\"confidenceOverrides\":[]}",
200);
// Clear target major version
tester.assertResponse(
operatorRequest("http://localhost:8080/controller/v1/jobs/upgrader", "{\"targetMajorVersion\":null}", Request.Method.PATCH),
"{\"upgradesPerMinute\":42.0,\"confidenceOverrides\":[]}",
200);
// Override confidence
tester.assertResponse(
operatorRequest("http://localhost:8080/controller/v1/jobs/upgrader/confidence/6.42", "broken", Request.Method.POST),
"{\"upgradesPerMinute\":42.0,\"confidenceOverrides\":[{\"6.42\":\"broken\"}]}",
200);
// Override confidence for another version
tester.assertResponse(
operatorRequest("http://localhost:8080/controller/v1/jobs/upgrader/confidence/6.43", "broken", Request.Method.POST),
"{\"upgradesPerMinute\":42.0,\"confidenceOverrides\":[{\"6.42\":\"broken\"},{\"6.43\":\"broken\"}]}",
200);
// Remove first override
tester.assertResponse(
operatorRequest("http://localhost:8080/controller/v1/jobs/upgrader/confidence/6.42", "", Request.Method.DELETE),
"{\"upgradesPerMinute\":42.0,\"confidenceOverrides\":[{\"6.43\":\"broken\"}]}",
200);
assertFalse("Actions are logged to audit log", tester.controller().auditLogger().readLog().entries().isEmpty());
}
@Test
public void testAuditLogApi() {
ManualClock clock = new ManualClock(Instant.parse("2019-03-01T12:13:14.00Z"));
AuditLogger logger = new AuditLogger(tester.controller().curator(), clock);
// Log some operator actions
HttpRequest req1 = HttpRequest.createTestRequest(
"http://localhost:8080/controller/v1/maintenance/inactive/DeploymentExpirer",
com.yahoo.jdisc.http.HttpRequest.Method.POST
);
req1.getJDiscRequest().setUserPrincipal(() -> "operator1");
logger.log(req1);
clock.advance(Duration.ofHours(2));
HttpRequest req2 = HttpRequest.createTestRequest(
"http://localhost:8080/controller/v1/jobs/upgrader/confidence/6.42",
com.yahoo.jdisc.http.HttpRequest.Method.POST,
new ByteArrayInputStream("broken".getBytes(StandardCharsets.UTF_8))
);
req2.getJDiscRequest().setUserPrincipal(() -> "operator2");
logger.log(req2);
// Verify log
tester.assertResponse(authenticatedRequest("http://localhost:8080/controller/v1/auditlog/"), new File("auditlog.json"));
}
@Test
public void testMeteringApi() {
ApplicationId applicationId = ApplicationId.from("tenant", "app", "instance");
Instant timestamp = Instant.ofEpochMilli(123456789);
ZoneId zoneId = ZoneId.defaultId();
List<ResourceSnapshot> snapshots = List.of(
new ResourceSnapshot(applicationId, 12,48,1200, NodeResources.Architecture.arm64, timestamp, zoneId),
new ResourceSnapshot(applicationId, 24, 96,2400, NodeResources.Architecture.x86_64, timestamp, zoneId)
);
tester.controller().serviceRegistry().resourceDatabase().writeResourceSnapshots(snapshots);
tester.assertResponse(
operatorRequest("http://localhost:8080/controller/v1/metering/tenant/tenantName/month/2020-02", "", Request.Method.GET),
new File("metering.json")
);
}
@Test
public void testApproveMembership() {
ApplicationId applicationId = ApplicationId.from("tenant", "app", "instance");
DeploymentId deployment = new DeploymentId(applicationId, ZoneId.defaultId());
String requestBody = "{\n" +
" \"applicationId\": \"" + deployment.applicationId().serializedForm() + "\",\n" +
" \"zone\": \"" + deployment.zoneId().value() + "\"\n" +
"}";
MockAccessControlService accessControlService = (MockAccessControlService) tester.serviceRegistry().accessControlService();
tester.assertResponse(operatorRequest("http://localhost:8080/controller/v1/access/requests/"+hostedOperator.getName(), requestBody, Request.Method.POST),
"{\"message\":\"Unable to approve membership request\"}", 400);
accessControlService.addPendingMember(hostedOperator);
tester.assertResponse(operatorRequest("http://localhost:8080/controller/v1/access/requests/"+hostedOperator.getName(), requestBody, Request.Method.POST),
"{\"message\":\"Unable to approve membership request\"}", 400);
tester.controller().supportAccess().allow(deployment, tester.controller().clock().instant().plus(Duration.ofHours(1)), "tenantx");
tester.assertResponse(operatorRequest("http://localhost:8080/controller/v1/access/requests/"+hostedOperator.getName(), requestBody, Request.Method.POST),
"{\"members\":[\"user.alice\"]}");
}
}
|
