aboutsummaryrefslogtreecommitdiffstats
path: root/jdisc_core_test/integration_test/src/test/java/com/yahoo/jdisc/core/BundleCollisionHookIntegrationTest.java
blob: 58c6c1ba8d6a72f6546e7b66d29d77652125c397 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
package com.yahoo.jdisc.core;

import com.yahoo.jdisc.test.TestDriver;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.osgi.framework.Bundle;
import org.osgi.framework.BundleException;

import java.util.Collections;

import static com.yahoo.jdisc.core.FelixFrameworkIntegrationTest.startBundle;
import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;

/**
 * Note that the '-dup' bundles are necessary, because felix ignores duplicate bundles with the same location.
 *
 * @author gjoranv
 */
public class BundleCollisionHookIntegrationTest {

    private FelixFramework felix;

    @Before
    public void startFelix() throws  Exception {
        felix = TestDriver.newOsgiFramework();
        felix.start();
    }

    @After
    public void stopFelix() throws Exception {
        felix.stop();
    }

    @Test
    public void duplicate_bundles_cannot_be_installed_in_general() throws Exception {
        startBundle(felix, "cert-l1.jar");
        try {
            startBundle(felix, "cert-l1-dup.jar");
            fail("Expected exception due to duplicate bundles");
        } catch (BundleException e) {
            assertTrue(e.getMessage().contains("Bundle symbolic name and version are not unique"));
        }
    }

    @Test
    public void duplicate_bundles_can_be_installed_if_bsn_version_is_whitelisted() throws Exception {
        Bundle bundleL = startBundle(felix, "cert-l1.jar");
        felix.allowDuplicateBundles(Collections.singleton(bundleL));

        Bundle bundleLdup = startBundle(felix, "cert-l1-dup.jar");
        assertNotEquals(bundleL.getBundleId(), bundleLdup.getBundleId());
    }

    @Test
    public void duplicates_whitelist_is_updated_when_bundles_are_uninstalled() throws Exception {
        Bundle bundleL = startBundle(felix, "cert-l1.jar");
        felix.allowDuplicateBundles(Collections.singleton(bundleL));

        startBundle(felix, "cert-l1-dup.jar");

        // Remove the original bundle -> will also remove the allowed duplicate
        bundleL.uninstall();

        // Trigger error by trying to re-install the bundle while the duplicate remains
        try {
            startBundle(felix, "cert-l1.jar");
            fail("Expected exception due to duplicate bundles");
        } catch (BundleException e) {
            assertTrue(e.getMessage().contains("Bundle symbolic name and version are not unique"));
        }

    }

    @Test
    public void duplicates_whitelist_can_be_updated_with_additional_bundles() throws Exception {
        Bundle bundleL = startBundle(felix, "cert-l1.jar");
        Bundle bundleMl = startBundle(felix, "cert-ml.jar");
        felix.allowDuplicateBundles(Collections.singleton(bundleL));
        felix.allowDuplicateBundles(Collections.singleton(bundleMl));

        startBundle(felix, "cert-l1-dup.jar");
        startBundle(felix, "cert-ml-dup.jar");
    }

}