aboutsummaryrefslogtreecommitdiffstats
path: root/vespaclient-container-plugin/src/test/java/com/yahoo/document/restapi/resource/DocumentV1ApiTest.java
blob: 3a8456d213dc124ecc8da653e634a797eb296d86 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
// Copyright Vespa.ai. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.document.restapi.resource;

import com.yahoo.cloud.config.ClusterListConfig;
import com.yahoo.container.jdisc.RequestHandlerTestDriver;
import com.yahoo.document.BucketId;
import com.yahoo.document.Document;
import com.yahoo.document.DocumentId;
import com.yahoo.document.DocumentPut;
import com.yahoo.document.DocumentRemove;
import com.yahoo.document.DocumentTypeManager;
import com.yahoo.document.DocumentUpdate;
import com.yahoo.document.FixedBucketSpaces;
import com.yahoo.document.TestAndSetCondition;
import com.yahoo.document.config.DocumentmanagerConfig;
import com.yahoo.document.datatypes.StringFieldValue;
import com.yahoo.document.datatypes.TensorFieldValue;
import com.yahoo.document.restapi.DocumentOperationExecutorConfig;
import com.yahoo.document.restapi.resource.DocumentV1ApiHandler.StorageCluster;
import com.yahoo.document.update.FieldUpdate;
import com.yahoo.documentapi.AckToken;
import com.yahoo.documentapi.AsyncParameters;
import com.yahoo.documentapi.AsyncSession;
import com.yahoo.documentapi.DocumentAccess;
import com.yahoo.documentapi.DocumentAccessParams;
import com.yahoo.documentapi.DocumentIdResponse;
import com.yahoo.documentapi.DocumentOperationParameters;
import com.yahoo.documentapi.DocumentResponse;
import com.yahoo.documentapi.ProgressToken;
import com.yahoo.documentapi.Response;
import com.yahoo.documentapi.ResponseHandler;
import com.yahoo.documentapi.Result;
import com.yahoo.documentapi.SubscriptionParameters;
import com.yahoo.documentapi.SubscriptionSession;
import com.yahoo.documentapi.SyncParameters;
import com.yahoo.documentapi.SyncSession;
import com.yahoo.documentapi.UpdateResponse;
import com.yahoo.documentapi.VisitorControlHandler;
import com.yahoo.documentapi.VisitorDestinationParameters;
import com.yahoo.documentapi.VisitorDestinationSession;
import com.yahoo.documentapi.VisitorIterator;
import com.yahoo.documentapi.VisitorParameters;
import com.yahoo.documentapi.VisitorResponse;
import com.yahoo.documentapi.VisitorSession;
import com.yahoo.documentapi.messagebus.protocol.PutDocumentMessage;
import com.yahoo.documentapi.messagebus.protocol.RemoveDocumentMessage;
import com.yahoo.jdisc.test.MockMetric;
import com.yahoo.messagebus.StaticThrottlePolicy;
import com.yahoo.messagebus.Trace;
import com.yahoo.messagebus.TraceNode;
import com.yahoo.metrics.simple.MetricReceiver;
import com.yahoo.schema.derived.Deriver;
import com.yahoo.slime.Inspector;
import com.yahoo.slime.JsonFormat;
import com.yahoo.slime.SlimeUtils;
import com.yahoo.tensor.Tensor;
import com.yahoo.test.ManualClock;
import com.yahoo.vdslib.VisitorStatistics;
import com.yahoo.vespa.config.content.AllClustersBucketSpacesConfig;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;

import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.UncheckedIOException;
import java.time.Duration;
import java.util.Collection;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
import java.util.TreeMap;
import java.util.concurrent.BlockingQueue;
import java.util.concurrent.CopyOnWriteArraySet;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.Executors;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicReference;
import java.util.function.BiFunction;
import java.util.function.Consumer;

import static com.yahoo.documentapi.DocumentOperationParameters.parameters;
import static com.yahoo.jdisc.http.HttpRequest.Method.DELETE;
import static com.yahoo.jdisc.http.HttpRequest.Method.OPTIONS;
import static com.yahoo.jdisc.http.HttpRequest.Method.PATCH;
import static com.yahoo.jdisc.http.HttpRequest.Method.POST;
import static com.yahoo.jdisc.http.HttpRequest.Method.PUT;
import static java.nio.charset.StandardCharsets.UTF_8;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;

/**
 * @author jonmv
 */
public class DocumentV1ApiTest {

    final AllClustersBucketSpacesConfig bucketConfig = new AllClustersBucketSpacesConfig.Builder()
            .cluster("content",
                     new AllClustersBucketSpacesConfig.Cluster.Builder()
                             .documentType("music",
                                           new AllClustersBucketSpacesConfig.Cluster.DocumentType.Builder()
                                                   .bucketSpace(FixedBucketSpaces.defaultSpace())))
            .build();
    final ClusterListConfig clusterConfig = new ClusterListConfig.Builder()
            .storage(new ClusterListConfig.Storage.Builder().configid("config-id")
                                                            .name("content"))
            .build();
    final DocumentOperationExecutorConfig executorConfig = new DocumentOperationExecutorConfig.Builder()
            .maxThrottled(2)
            .maxThrottledAge(1.0)
            .resendDelayMillis(1 << 30)
            .build();
    final DocumentmanagerConfig docConfig = Deriver.getDocumentManagerConfig("src/test/cfg/music.sd")
                                                   .ignoreundefinedfields(true).build();
    final DocumentTypeManager manager = new DocumentTypeManager(docConfig);
    final Document doc1 = new Document(manager.getDocumentType("music"), "id:space:music::one");
    final Document doc2 = new Document(manager.getDocumentType("music"), "id:space:music:n=1:two");
    final Document doc3 = new Document(manager.getDocumentType("music"), "id:space:music:g=a:three");
    {
        doc1.setFieldValue("artist", "Tom Waits");
        doc1.setFieldValue("embedding", new TensorFieldValue(Tensor.from("tensor(x[3]):[1,2,3]")));
        doc2.setFieldValue("artist", "Asa-Chan & Jun-Ray");
        doc2.setFieldValue("embedding", new TensorFieldValue(Tensor.from("tensor(x[3]):[4,5,6]")));
    }

    final Map<String, StorageCluster> clusters = Map.of("content", new StorageCluster("content",
                                                                                      Map.of("music", "default")));
    ManualClock clock;
    MockDocumentAccess access;
    MockMetric metric;
    MetricReceiver metrics;
    DocumentV1ApiHandler handler;

    @Before
    public void setUp() {
        clock = new ManualClock();
        access = new MockDocumentAccess(docConfig);
        metric = new MockMetric();
        metrics = new MetricReceiver.MockReceiver();
        handler = new DocumentV1ApiHandler(clock, Duration.ofMillis(1), metric, metrics, access, docConfig,
                                           executorConfig, clusterConfig, bucketConfig);
    }

    @After
    public void tearDown() {
        handler.destroy();
    }

    @Test
    public void testResolveCluster() {
        assertEquals("content",
                     DocumentV1ApiHandler.resolveCluster(Optional.empty(), clusters).name());
        assertEquals("content",
                     DocumentV1ApiHandler.resolveCluster(Optional.of("content"), clusters).name());
        try {
            DocumentV1ApiHandler.resolveCluster(Optional.empty(), Map.of());
            fail("Should fail without any clusters");
        }
        catch (IllegalArgumentException e) {
            assertEquals("Your Vespa deployment has no content clusters, so the document API is not enabled", e.getMessage());
        }
        try {
            DocumentV1ApiHandler.resolveCluster(Optional.of("blargh"), clusters);
            fail("Should not find this cluster");
        }
        catch (IllegalArgumentException e) {
            assertEquals("Your Vespa deployment has no content cluster 'blargh', only 'content'", e.getMessage());
        }
        try {
            Map<String, StorageCluster> twoClusters = new TreeMap<>();
            twoClusters.put("one", new StorageCluster("one", Map.of()));
            twoClusters.put("two", new StorageCluster("two", Map.of()));
            DocumentV1ApiHandler.resolveCluster(Optional.empty(), twoClusters);
            fail("More than one cluster and no document type should fail");
        }
        catch (IllegalArgumentException e) {
            assertEquals("Please specify one of the content clusters in your Vespa deployment: 'one', 'two'", e.getMessage());
        }
        StorageCluster cluster = DocumentV1ApiHandler.resolveCluster(Optional.of("content"), clusters);
        assertEquals(FixedBucketSpaces.defaultSpace(),
                     DocumentV1ApiHandler.resolveBucket(cluster, Optional.of("music"), List.of(), Optional.empty()));
        assertEquals(FixedBucketSpaces.globalSpace(),
                     DocumentV1ApiHandler.resolveBucket(cluster, Optional.empty(), List.of(FixedBucketSpaces.globalSpace()), Optional.of("global")));
    }

    @Test
    public void testOverLoadBySize() {
        RequestHandlerTestDriver driver = new RequestHandlerTestDriver(handler);
        // OVERLOAD is a 429
        access.session.expect((id, parameters) -> new Result(Result.ResultType.TRANSIENT_ERROR, Result.toError(Result.ResultType.TRANSIENT_ERROR)));
        var response1 = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two", POST, "{\"fields\": {}}");
        var response2 = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two", POST, "{\"fields\": {}}");
        var response3 = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two", POST, "{\"fields\": {}}");
        assertSameJson("{" +
                "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                "  \"message\": \"Rejecting execution due to overload: 2 requests already enqueued\"" +
                "}", response3.readAll());
        assertEquals(429, response3.getStatus());

        access.session.expect((id, parameters) -> new Result(Result.ResultType.FATAL_ERROR, Result.toError(Result.ResultType.FATAL_ERROR)));
        handler.dispatchEnqueued();
        assertSameJson("{" +
                "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                "  \"message\": \"[FATAL_ERROR @ localhost]: FATAL_ERROR\"" +
                "}", response1.readAll());
        assertEquals(500, response1.getStatus());
        assertSameJson("{" +
                "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                "  \"message\": \"[FATAL_ERROR @ localhost]: FATAL_ERROR\"" +
                "}", response2.readAll());
        assertEquals(500, response2.getStatus());
        driver.close();
    }

    @Test
    public void testOverLoadByAge() {
        RequestHandlerTestDriver driver = new RequestHandlerTestDriver(handler);
        // OVERLOAD is a 429
        access.session.expect((id, parameters) -> new Result(Result.ResultType.TRANSIENT_ERROR, Result.toError(Result.ResultType.TRANSIENT_ERROR)));
        var response1 = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two", POST, "{\"fields\": {}}");
        try { Thread.sleep(3_000); } catch (InterruptedException e) {}
        var response2 = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two", POST, "{\"fields\": {}}");
        assertSameJson("{" +
                "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                "  \"message\": \"Rejecting execution due to overload: 1.0 seconds worth of work enqueued\"" +
                "}", response2.readAll());
        assertEquals(429, response2.getStatus());

        access.session.expect((id, parameters) -> new Result(Result.ResultType.FATAL_ERROR, Result.toError(Result.ResultType.FATAL_ERROR)));
        handler.dispatchEnqueued();
        assertSameJson("{" +
                "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                "  \"message\": \"[FATAL_ERROR @ localhost]: FATAL_ERROR\"" +
                "}", response1.readAll());
        assertEquals(500, response1.getStatus());
        driver.close();
    }

    @Test
    public void testResponses() {
        RequestHandlerTestDriver driver = new RequestHandlerTestDriver(handler);
        List<AckToken> tokens = List.of(new AckToken(null), new AckToken(null), new AckToken(null), new AckToken(null));
        // GET at non-existent path returns 404 with available paths
        var response = driver.sendRequest("http://localhost/document/v1/not-found");
        assertSameJson("""
                       {
                         "pathId": "/document/v1/not-found",
                         "message": "Nothing at '/document/v1/not-found'. Available paths are:
                       /document/v1/
                       /document/v1/{namespace}/{documentType}/docid/
                       /document/v1/{namespace}/{documentType}/group/{group}/
                       /document/v1/{namespace}/{documentType}/number/{number}/
                       /document/v1/{namespace}/{documentType}/docid/{*}
                       /document/v1/{namespace}/{documentType}/group/{group}/{*}
                       /document/v1/{namespace}/{documentType}/number/{number}/{*}"
                       }""", response.readAll());
        assertEquals("application/json; charset=UTF-8", response.getResponse().headers().getFirst("Content-Type"));
        assertEquals(404, response.getStatus());

        // GET at root is a visit. Numeric parameters have an upper bound.
        access.expect(tokens);
        Trace visitorTrace = new Trace(9);
        visitorTrace.trace(7, "Tracy Chapman", false);
        visitorTrace.getRoot().addChild(new TraceNode().setStrict(false)
                                                .addChild("Fast Car")
                                                .addChild("Baby Can I Hold You"));
        access.visitorTrace = visitorTrace;
        access.expect(parameters -> {
            assertEquals("content", parameters.getRoute().toString());
            assertEquals("default", parameters.getBucketSpace());
            assertEquals(1025, parameters.getMaxTotalHits());
            assertEquals(100, ((StaticThrottlePolicy) parameters.getThrottlePolicy()).getMaxPendingCount());
            assertEquals("[id]", parameters.getFieldSet());
            assertEquals("(all the things)", parameters.getDocumentSelection());
            assertTrue(6000 <= parameters.getSessionTimeoutMs()); // Static clock in handler < connected time for request, test artefact.
            assertEquals(9, parameters.getTraceLevel());
            assertEquals(1_000_000, parameters.getFromTimestamp());
            assertEquals(2_000_000, parameters.getToTimestamp());
            assertTrue(parameters.visitRemoves());
            // Put some documents in the response
            parameters.getLocalDataHandler().onMessage(new PutDocumentMessage(new DocumentPut(doc1)), tokens.get(0));
            parameters.getLocalDataHandler().onMessage(new PutDocumentMessage(new DocumentPut(doc2)), tokens.get(1));
            parameters.getLocalDataHandler().onMessage(new PutDocumentMessage(new DocumentPut(doc3)), tokens.get(2));
            parameters.getLocalDataHandler().onMessage(new RemoveDocumentMessage(new DocumentId("id:space:music::t-square-truth")), tokens.get(3));
            VisitorStatistics statistics = new VisitorStatistics();
            statistics.setBucketsVisited(1);
            statistics.setDocumentsVisited(123); // Ignored in favor of tracking actually emitted entries
            parameters.getControlHandler().onVisitorStatistics(statistics);
            parameters.getControlHandler().onDone(VisitorControlHandler.CompletionCode.TIMEOUT, "timeout is OK");
        });
        response = driver.sendRequest("http://localhost/document/v1?cluster=content&bucketSpace=default&wantedDocumentCount=1025" +
                                      "&concurrency=123&selection=all%20the%20things&fieldSet=[id]&timeout=6&tracelevel=9" +
                                      "&fromTimestamp=1000000&toTimestamp=2000000&includeRemoves=TrUe");
        assertSameJson("""
                       {
                         "pathId": "/document/v1",
                         "documents": [
                           {
                             "id": "id:space:music::one",
                             "fields": {
                               "artist": "Tom Waits",
                               "embedding": { "type": "tensor(x[3])", "values": [1.0,2.0,3.0] }
                             }
                           },
                           {
                             "id": "id:space:music:n=1:two",
                             "fields": {
                               "artist": "Asa-Chan & Jun-Ray",
                               "embedding": { "type": "tensor(x[3])", "values": [4.0,5.0,6.0] }
                             }
                           },
                           {
                            "id": "id:space:music:g=a:three",
                            "fields": {}
                           },
                           {
                            "remove": "id:space:music::t-square-truth"
                           }
                         ],
                         "documentCount": 4,
                         "trace": [
                           { "message": "Tracy Chapman" },
                           {
                             "fork": [
                               { "message": "Fast Car" },
                               { "message": "Baby Can I Hold You" }
                             ]
                           }
                         ]
                       }""", response.readAll());
        assertEquals(200, response.getStatus());
        access.visitorTrace = null;

        // GET at root is a visit. Streaming mode can be specified with &stream=true
        access.expect(tokens);
        access.expect(parameters -> {
            assertEquals("content", parameters.getRoute().toString());
            assertEquals("default", parameters.getBucketSpace());
            assertEquals(1025, parameters.getMaxTotalHits()); // Not bounded likewise for streamed responses.
            assertEquals(1, ((StaticThrottlePolicy) parameters.getThrottlePolicy()).getMaxPendingCount());
            assertEquals("[id]", parameters.getFieldSet());
            assertEquals("(all the things)", parameters.getDocumentSelection());
            assertTrue(6000 <= parameters.getTimeoutMs()); // Static clock in handler < connected time for request, test artefact.
            assertEquals(4, parameters.getSlices());
            assertEquals(1, parameters.getSliceId());
            assertEquals(0, parameters.getFromTimestamp()); // not set; 0 is default
            assertEquals(0, parameters.getToTimestamp()); // not set; 0 is default
            assertFalse(parameters.visitRemoves()); // false by default
            // Put some documents in the response
            parameters.getLocalDataHandler().onMessage(new PutDocumentMessage(new DocumentPut(doc1)), tokens.get(0));
            parameters.getLocalDataHandler().onMessage(new PutDocumentMessage(new DocumentPut(doc2)), tokens.get(1));
            VisitorStatistics statistics = new VisitorStatistics();
            statistics.setBucketsVisited(1);
            statistics.setDocumentsVisited(2);
            parameters.getControlHandler().onVisitorStatistics(statistics);
            parameters.getControlHandler().onDone(VisitorControlHandler.CompletionCode.TIMEOUT, "timeout is OK");
            // Extra documents are ignored.
            parameters.getLocalDataHandler().onMessage(new PutDocumentMessage(new DocumentPut(doc3)), tokens.get(2));
        });
        response = driver.sendRequest("http://localhost/document/v1?cluster=content&bucketSpace=default&wantedDocumentCount=1025&concurrency=123" +
                                      "&selection=all%20the%20things&fieldSet=[id]&timeout=6&stream=true&slices=4&sliceId=1");
        assertSameJson("""
                       {
                         "pathId": "/document/v1",
                         "documents": [
                           {
                             "id": "id:space:music::one",
                             "fields": {
                               "artist": "Tom Waits",
                               "embedding": { "type": "tensor(x[3])", "values": [1.0,2.0,3.0] }
                             }
                           },
                           {
                             "id": "id:space:music:n=1:two",
                             "fields": {
                               "artist": "Asa-Chan & Jun-Ray",
                               "embedding": { "type": "tensor(x[3])", "values": [4.0,5.0,6.0] }
                             }
                           }
                         ],
                         "documentCount": 2
                       }""", response.readAll());
        assertEquals(200, response.getStatus());

        // GET with namespace and document type is a restricted visit.
        ProgressToken progress = new ProgressToken();
        VisitorIterator.createFromExplicitBucketSet(Set.of(new BucketId(1), new BucketId(2)), 8, progress)
                       .update(new BucketId(1), new BucketId(1));
        access.expect(parameters -> {
            assertEquals("(music) and (id.namespace=='space')", parameters.getDocumentSelection());
            assertEquals(progress.serializeToString(), parameters.getResumeToken().serializeToString());
            throw new IllegalArgumentException("parse failure");
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/docid?continuation=" + progress.serializeToString());
        assertSameJson("""
                       {
                         "pathId": "/document/v1/space/music/docid",
                         "message": "parse failure"
                       }""",
                       response.readAll());
        assertEquals(400, response.getStatus());

        // GET when a streamed visit returns status code 200 also when errors occur.
        access.expect(parameters -> {
            assertEquals("(music) and (id.namespace=='space')", parameters.getDocumentSelection());
            parameters.getControlHandler().onProgress(progress);
            parameters.getControlHandler().onDone(VisitorControlHandler.CompletionCode.FAILURE, "failure?");
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/docid?stream=true");
        assertSameJson("""
                       {
                         "pathId": "/document/v1/space/music/docid",
                         "documents": [],
                         "documentCount": 0,
                         "message": "failure?"
                       }""", response.readAll());
        assertEquals(200, response.getStatus());
        assertNull(response.getResponse().headers().get("X-Vespa-Ignored-Fields"));

        // POST with namespace and document type is a restricted visit with a required destination cluster ("destinationCluster")
        access.expect(parameters -> {
            fail("Not supposed to run");
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/docid", POST);
        assertSameJson("""
                       {
                         "pathId": "/document/v1/space/music/docid",
                         "message": "Must specify 'destinationCluster' at '/document/v1/space/music/docid'"
                       }""",
                       response.readAll());
        assertEquals(400, response.getStatus());

        // POST with namespace and document type is a restricted visit with a required destination cluster ("destinationCluster")
        access.expect(parameters -> {
            assertEquals("[Content:cluster=content]", parameters.getRemoteDataHandler());
            assertEquals("[document]", parameters.fieldSet());
            assertEquals(60_000L, parameters.getSessionTimeoutMs());
            parameters.getControlHandler().onDone(VisitorControlHandler.CompletionCode.SUCCESS, "We made it!");
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/docid?destinationCluster=content&selection=true&cluster=content&timeout=60", POST);
        assertSameJson("""
                       {
                         "pathId": "/document/v1/space/music/docid",
                         "documentCount": 0
                       }""",
                       response.readAll());
        assertEquals(200, response.getStatus());

        // PUT with namespace and document type is a restricted visit with a required partial update to apply to visited documents.
        access.expect(tokens.subList(2, 3));
        access.expect(parameters -> {
            assertEquals("(true) and (music) and (id.namespace=='space')", parameters.getDocumentSelection());
            assertEquals("[id]", parameters.fieldSet());
            assertEquals(10_000, parameters.getSessionTimeoutMs());
            parameters.getLocalDataHandler().onMessage(new PutDocumentMessage(new DocumentPut(doc3)), tokens.get(2));
            parameters.getControlHandler().onDone(VisitorControlHandler.CompletionCode.TIMEOUT, "Won't care");
        });
        access.session.expect((update, parameters) -> {
            DocumentUpdate expectedUpdate = new DocumentUpdate(doc3.getDataType(), doc3.getId());
            expectedUpdate.addFieldUpdate(FieldUpdate.createAssign(doc3.getField("artist"), new StringFieldValue("Lisa Ekdahl")));
            expectedUpdate.setCondition(new TestAndSetCondition("true"));
            expectedUpdate.setCreateIfNonExistent(true);
            assertEquals(expectedUpdate, update);
            parameters.responseHandler().get().handleResponse(new UpdateResponse(0, false));
            assertEquals(parameters().withRoute("content"), parameters);
            return new Result();
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/docid?selection=true&cluster=content&timeChunk=10", PUT,
                                      """
                                      {
                                        "extra-ignored-field": { "foo": [{ }], "bar": null },
                                        "another-ignored-field": [{ "foo": [{ }] }],
                                        "remove": "id:ns:type::ignored",
                                        "put": "id:ns:type::ignored",
                                        "fields": {
                                          "artist": { "assign": "Lisa Ekdahl" },
                                          "nonexisting": { "assign": "Ignored" }
                                        },
                                        "post": "id:ns:type::ignored",
                                        "create": true
                                      }""");
        assertSameJson("""
                       {
                         "pathId": "/document/v1/space/music/docid",
                         "documentCount": 1
                       }""",
                       response.readAll());
        assertEquals(200, response.getStatus());
        assertEquals("true", response.getResponse().headers().get("X-Vespa-Ignored-Fields").get(0).toString());

        // PUT with namespace, document type and group is also a restricted visit which requires a cluster.
        access.expect(parameters -> {
            fail("Not supposed to run");
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/group/troupe?selection=false", PUT);
        assertSameJson("""
                       {
                         "pathId": "/document/v1/space/music/group/troupe",
                         "message": "Must specify 'cluster' at '/document/v1/space/music/group/troupe'"
                       }""",
                       response.readAll());
        assertEquals(400, response.getStatus());

        // PUT with namespace, document type and group is also a restricted visit which requires a selection.
        access.expect(parameters -> {
            fail("Not supposed to run");
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/group/troupe?cluster=content", PUT);
        assertSameJson("""
                       {
                         "pathId": "/document/v1/space/music/group/troupe",
                         "message": "Must specify 'selection' at '/document/v1/space/music/group/troupe'"
                       }""",
                       response.readAll());
        assertEquals(400, response.getStatus());

        // DELETE with namespace and document type is a restricted visit which deletes visited documents.
        // When visiting fails fatally, a 500 INTERAL SERVER ERROR is returned.
        access.expect(tokens.subList(0, 1));
        access.expect(parameters -> {
            assertEquals("(false) and (music) and (id.namespace=='space')", parameters.getDocumentSelection());
            assertEquals("[id]", parameters.fieldSet());
            assertEquals(60_000, parameters.getSessionTimeoutMs());
            parameters.getLocalDataHandler().onMessage(new PutDocumentMessage(new DocumentPut(doc2)), tokens.get(0));
            parameters.getControlHandler().onDone(VisitorControlHandler.CompletionCode.ABORTED, "Huzzah?");
        });
        access.session.expect((remove, parameters) -> {
            DocumentRemove expectedRemove = new DocumentRemove(doc2.getId());
            expectedRemove.setCondition(new TestAndSetCondition("false"));
            assertEquals(expectedRemove, remove);
            assertEquals(parameters().withRoute("content"), parameters);
            parameters.responseHandler().get().handleResponse(new DocumentIdResponse(0, doc2.getId(), "boom", Response.Outcome.ERROR));
            return new Result();
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/docid?selection=false&cluster=content", DELETE);
        assertSameJson("""
                       {
                         "pathId": "/document/v1/space/music/docid",
                         "documentCount": 1,
                         "message": "boom"
                       }""",
                       response.readAll());
        assertEquals(500, response.getStatus());

        // DELETE at the root is also a deletion visit. These also require a selection.
        access.expect(parameters -> {
            fail("Not supposed to run");
        });
        response = driver.sendRequest("http://localhost/document/v1/", DELETE);
        assertSameJson("""
                       {
                         "pathId": "/document/v1/",
                         "message": "Must specify 'selection' at '/document/v1/'"
                       }""",
                       response.readAll());
        assertEquals(400, response.getStatus());

        // DELETE at the root is also a deletion visit. These also require a cluster.
        access.expect(parameters -> {
            fail("Not supposed to run");
        });
        response = driver.sendRequest("http://localhost/document/v1/?selection=true", DELETE);
        assertSameJson("""
                       {
                         "pathId": "/document/v1/",
                         "message": "Must specify 'cluster' at '/document/v1/'"
                       }""",
                       response.readAll());
        assertEquals(400, response.getStatus());

        // GET with namespace, document type and group is a restricted visit.
        access.expect(parameters -> {
            assertEquals("(music) and (id.namespace=='space') and (id.group=='best\\'')", parameters.getDocumentSelection());
            parameters.getControlHandler().onDone(VisitorControlHandler.CompletionCode.FAILURE, "error");
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/group/best%27");
        assertSameJson("""
                       {
                         "pathId": "/document/v1/space/music/group/best%27",
                         "documents": [],
                         "documentCount": 0,
                         "message": "error"
                       }""",
                       response.readAll());
        assertEquals(500, response.getStatus());

        // GET with namespace, document type and number is a restricted visit.
        access.expect(parameters -> {
            assertEquals("(music) and (id.namespace=='space') and (id.user==123)", parameters.getDocumentSelection());
            VisitorStatistics statistics = new VisitorStatistics();
            statistics.setBucketsVisited(1);
            statistics.setDocumentsVisited(0);
            parameters.getControlHandler().onVisitorStatistics(statistics);
            parameters.getControlHandler().onDone(VisitorControlHandler.CompletionCode.ABORTED, "aborted");
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/number/123");
        assertSameJson("""
                       {
                         "pathId": "/document/v1/space/music/number/123",
                         "documents": [ ],
                         "documentCount": 0
                       }""",
                       response.readAll());
        assertEquals(200, response.getStatus());

        // GET with from timestamp > to timestamp is an error
        access.expect(parameters -> { fail("unreachable"); });
        response = driver.sendRequest("http://localhost/document/v1/?cluster=content&fromTimestamp=100&toTimestamp=99");
        assertSameJson("""
                       {
                         "pathId": "/document/v1/",
                         "message": "toTimestamp must be greater than, or equal to, fromTimestamp"
                       }""",
                       response.readAll());
        assertEquals(400, response.getStatus());

        // GET with full document ID is a document get operation which returns 404 when no document is found
        access.session.expect((id, parameters) -> {
            assertEquals(doc1.getId(), id);
            assertEquals(parameters().withRoute("content").withFieldSet("go"), parameters);
            parameters.responseHandler().get().handleResponse(new DocumentResponse(0, null));
            return new Result();
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/docid/one?cluster=content&fieldSet=go&timeout=123");
        assertSameJson("""
                       {
                         "pathId": "/document/v1/space/music/docid/one",
                         "id": "id:space:music::one"
                       }""",
                       response.readAll());
        assertEquals(404, response.getStatus());

        // GET with full document ID is a document get operation.
        access.session.expect((id, parameters) -> {
            assertEquals(doc1.getId(), id);
            assertEquals(parameters().withFieldSet("music:[document]"), parameters);
            parameters.responseHandler().get().handleResponse(new DocumentResponse(0, doc1));
            return new Result();
        });
        // -- short tensors
        response = driver.sendRequest("http://localhost/document/v1/space/music/docid/one?format.tensors=short");
        String shortJson =
                """
                {
                  "pathId": "/document/v1/space/music/docid/one",
                  "id": "id:space:music::one",
                  "fields": {
                    "artist": "Tom Waits",
                    "embedding": { "type": "tensor(x[3])","values": [1.0, 2.0, 3.0]}
                  }
                }
               """;
        assertEquals(200, response.getStatus());
        assertSameJson(shortJson, response.readAll());
        // -- long tensors
        response = driver.sendRequest("http://localhost/document/v1/space/music/docid/one?format.tensors=long");
        String longJson =
                """
                {
                  "pathId": "/document/v1/space/music/docid/one",
                  "id": "id:space:music::one",
                  "fields": {
                    "artist": "Tom Waits",
                    "embedding": { "type": "tensor(x[3])","cells": [{"address":{"x":"0"},"value":1.0},{"address":{"x":"1"},"value": 2.0},{"address":{"x":"2"},"value": 3.0}]}
                  }
                }
               """;
        assertEquals(200, response.getStatus());
        assertSameJson(longJson, response.readAll());
        // -- short direct tensors
        response = driver.sendRequest("http://localhost/document/v1/space/music/docid/one?format.tensors=short-value");
        String shortDirectJson =
                """
                {
                  "pathId": "/document/v1/space/music/docid/one",
                  "id": "id:space:music::one",
                  "fields": {
                    "artist": "Tom Waits",
                    "embedding": [1.0, 2.0, 3.0]}
                  }
                }
               """;
        assertEquals(200, response.getStatus());
        assertSameJson(shortDirectJson, response.readAll());
        // -- long direct tensors
        response = driver.sendRequest("http://localhost/document/v1/space/music/docid/one?format.tensors=long-value");
        String longDirectJson =
                """
                {
                  "pathId": "/document/v1/space/music/docid/one",
                  "id": "id:space:music::one",
                  "fields": {
                    "artist": "Tom Waits",
                    "embedding": [{"address":{"x":"0"},"value":1.0},{"address":{"x":"1"},"value": 2.0},{"address":{"x":"2"},"value": 3.0}]
                  }
                }
               """;
        assertEquals(200, response.getStatus());
        assertSameJson(longDirectJson, response.readAll());

        // GET with not encoded / in user specified part of document id is perfectly OK ... щ(ಥДಥщ)
        access.session.expect((id, parameters) -> {
            assertEquals(new DocumentId("id:space:music::one/two/three"), id);
            assertEquals(parameters().withFieldSet("music:[document]"), parameters);
            parameters.responseHandler().get().handleResponse(new DocumentResponse(0));
            return new Result();
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/docid/one/two/three");
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/docid/one/two/three\"," +
                       "  \"id\": \"id:space:music::one/two/three\"" +
                       "}", response.readAll());
        assertEquals(404, response.getStatus());

        // GET with dryRun=true is an error
        access.session.expect((__, ___) -> {
            fail("Should not cause an actual feed operation");
            return null;
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two?dryRun=true");
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                       "  \"message\": \"May not specify 'dryRun' at '/document/v1/space/music/number/1/two'\"\n" +
                       "}", response.readAll());
        assertEquals(400, response.getStatus());

        // POST with dryRun=true returns an immediate OK response
        access.session.expect((__, ___) -> {
            fail("Should not cause an actual feed operation");
            return null;
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two?dryRun=true", POST,
                                      "NOT JSON, NOT PARSED");
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                       "  \"id\": \"id:space:music:n=1:two\"" +
                       "}", response.readAll());
        assertEquals(200, response.getStatus());

        // PUT with dryRun=true returns an immediate OK response
        access.session.expect((__, ___) -> {
            fail("Should not cause an actual feed operation");
            return null;
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two?dryRun=true", PUT,
                                      "NOT JSON, NOT PARSED");
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                       "  \"id\": \"id:space:music:n=1:two\"" +
                       "}", response.readAll());
        assertEquals(200, response.getStatus());

        // DELETE with dryRun=true returns an immediate OK response
        access.session.expect((__, ___) -> {
            fail("Should not cause an actual feed operation");
            return null;
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two?dryRun=true", DELETE,
                                      "NOT JSON, NOT PARSED");
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                       "  \"id\": \"id:space:music:n=1:two\"" +
                       "}", response.readAll());
        assertEquals(200, response.getStatus());

        // PUT with a document update payload is a document update operation.
        access.session.expect((update, parameters) -> {
            DocumentUpdate expectedUpdate = new DocumentUpdate(doc3.getDataType(), doc3.getId());
            expectedUpdate.addFieldUpdate(FieldUpdate.createAssign(doc3.getField("artist"), new StringFieldValue("Lisa Ekdahl")));
            expectedUpdate.setCreateIfNonExistent(true);
            assertEquals(expectedUpdate, update);
            assertEquals(parameters(), parameters);
            parameters.responseHandler().get().handleResponse(new UpdateResponse(0, true));
            return new Result();
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/group/a/three?create=true&timeout=1e1s&dryRun=false", PUT,
                                      "{" +
                                      "  \"fields\": {" +
                                      "    \"artist\": { \"assign\": \"Lisa Ekdahl\" }" +
                                      "  }" +
                                      "}");
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/group/a/three\"," +
                       "  \"id\": \"id:space:music:g=a:three\"" +
                       "}", response.readAll());
        assertEquals(200, response.getStatus());

        // POST with a document payload is a document put operation.
        access.session.expect((put, parameters) -> {
            DocumentPut expectedPut = new DocumentPut(doc2);
            expectedPut.setCondition(new TestAndSetCondition("test it"));
            expectedPut.setCreateIfNonExistent(true);
            assertEquals(expectedPut, put);
            assertEquals(parameters().withTraceLevel(9), parameters);
            Trace trace = new Trace(9);
            trace.trace(7, "Tracy Chapman", false);
            trace.getRoot().addChild(new TraceNode().setStrict(false)
                                                    .addChild("Fast Car")
                                                    .addChild("Baby Can I Hold You"));
            parameters.responseHandler().get().handleResponse(new DocumentResponse(0, doc2, trace));
            return new Result();
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two?create=true&condition=test%20it&tracelevel=9", POST,
                                      "{" +
                                      "  \"fields\": {" +
                                      "    \"artist\": \"Asa-Chan & Jun-Ray\"," +
                                      "    \"embedding\": { \"values\": [4.0,5.0,6.0] } " +
                                      "  }" +
                                      "}");
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                       "  \"id\": \"id:space:music:n=1:two\"," +
                       "  \"trace\": [" +
                       "    {" +
                       "      \"message\": \"Tracy Chapman\"" +
                       "    }," +
                       "    {" +
                       "      \"fork\": [" +
                       "        {" +
                       "          \"message\": \"Fast Car\"" +
                       "        }," +
                       "        {" +
                       "          \"message\": \"Baby Can I Hold You\"" +
                       "        }" +
                       "      ]" +
                       "    }" +
                       "  ]" +
                       "}", response.readAll());
        assertEquals(200, response.getStatus());

        // POST with no payload is a 400
        access.session.expect((__, ___) -> { throw new AssertionError("Not supposed to happen"); });
        response = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two?condition=test%20it", POST, "");
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                       "  \"message\": \"expected start of root object, got null\"" +
                       "}",
                       response.readAll());
        assertEquals(400, response.getStatus());

        // POST with illegal payload is a 400
        access.session.expect((__, ___) -> { throw new AssertionError("Not supposed to happen"); });
        response = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two?condition=test%20it", POST,
                                      "{" +
                                      "  ┻━┻︵ \\(°□°)/ ︵ ┻━┻" +
                                      "}");
        Inspector responseRoot = SlimeUtils.jsonToSlime(response.readAll()).get();
        assertEquals("/document/v1/space/music/number/1/two", responseRoot.field("pathId").asString());
        assertTrue(responseRoot.field("message").asString(),
                   responseRoot.field("message").asString().startsWith("failed parsing document: Unexpected character ('┻' (code 9531 / 0x253b)): was expecting double-quote to start field name"));
        assertEquals(400, response.getStatus());

        // PUT on a unknown document type is a 400
        access.session.expect((__, ___) -> { throw new AssertionError("Not supposed to happen"); });
        response = driver.sendRequest("http://localhost/document/v1/space/house/group/a/three?create=true", PUT,
                                      "{" +
                                      "  \"fields\": {" +
                                      "    \"artist\": { \"assign\": \"Lisa Ekdahl\" }" +
                                      "  }" +
                                      "}");
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/house/group/a/three\"," +
                       "  \"message\": \"Document type house does not exist\"" +
                       "}", response.readAll());
        assertEquals(400, response.getStatus());

        // PUT on document which is not found is a 200
        access.session.expect((update, parameters) -> {
            parameters.responseHandler().get().handleResponse(new UpdateResponse(0, false));
            return new Result();
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/docid/sonny", PUT,
                                      "{" +
                                      "  \"fields\": {" +
                                      "    \"artist\": { \"assign\": \"The Shivers\" }" +
                                      "  }" +
                                      "}");
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/docid/sonny\"," +
                       "  \"id\": \"id:space:music::sonny\"" +
                       "}", response.readAll());
        assertEquals(200, response.getStatus());

        // DELETE with full document ID is a document remove operation.
        access.session.expect((remove, parameters) -> {
            DocumentRemove expectedRemove = new DocumentRemove(doc2.getId());
            expectedRemove.setCondition(new TestAndSetCondition("false"));
            assertEquals(expectedRemove, remove);
            assertEquals(parameters().withRoute("route"), parameters);
            parameters.responseHandler().get().handleResponse(new DocumentIdResponse(0, doc2.getId()));
            return new Result();
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two?route=route&condition=false", DELETE);
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                       "  \"id\": \"id:space:music:n=1:two\"" +
                       "}", response.readAll());
        assertEquals(200, response.getStatus());

        // GET with empty route is a 400
        access.session.expect((__, ___) -> { throw new AssertionError("Not supposed to happen"); });
        response = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two?route=", DELETE);
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                       "  \"message\": \"Expected non-empty value for request property 'route'\"" +
                       "}", response.readAll());
        assertEquals(400, response.getStatus());

        // GET with non-existent cluster is a 400
        access.session.expect((__, ___) -> { throw new AssertionError("Not supposed to happen"); });
        response = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two?cluster=throw-me");
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                       "  \"message\": \"Your Vespa deployment has no content cluster 'throw-me', only 'content'\"" +
                       "}", response.readAll());
        assertEquals(400, response.getStatus());

        // TIMEOUT is a 504
        access.session.expect((id, parameters) -> {
            assertFalse(clock.instant().plusSeconds(1000).isAfter(parameters.deadline().get())); // Static clock in handler vs real clock in Request.
            parameters.responseHandler().get().handleResponse(new Response(0, "timeout", Response.Outcome.TIMEOUT));
            return new Result();
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two?timeout=1ks");
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                       "  \"id\": \"id:space:music:n=1:two\"," +
                       "  \"message\": \"timeout\"" +
                       "}", response.readAll());
        assertEquals(504, response.getStatus());

        // INSUFFICIENT_STORAGE is a 507
        access.session.expect((id, parameters) -> {
            parameters.responseHandler().get().handleResponse(new Response(0, "disk full", Response.Outcome.INSUFFICIENT_STORAGE));
            return new Result();
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two", DELETE);
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                       "  \"id\": \"id:space:music:n=1:two\"," +
                       "  \"message\": \"disk full\"" +
                       "}", response.readAll());
        assertEquals(507, response.getStatus());

        // PRECONDITION_FAILED is a 412
        access.session.expect((id, parameters) -> {
            parameters.responseHandler().get().handleResponse(new Response(0, "no dice", Response.Outcome.CONDITION_FAILED));
            return new Result();
        });
        response = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two", DELETE);
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/number/1/two\"," +
                       "  \"id\": \"id:space:music:n=1:two\"," +
                       "  \"message\": \"no dice\"" +
                       "}", response.readAll());
        assertEquals(412, response.getStatus());

        // OPTIONS gets options
        access.session.expect((__, ___) -> { throw new AssertionError("Not supposed to happen"); });
        response = driver.sendRequest("https://localhost/document/v1/space/music/docid/one", OPTIONS);
        assertEquals("", response.readAll());
        assertEquals(204, response.getStatus());
        assertEquals("GET,POST,PUT,DELETE", response.getResponse().headers().getFirst("Allow"));

        // PATCH is not allowed
        access.session.expect((__, ___) -> { throw new AssertionError("Not supposed to happen"); });
        response = driver.sendRequest("https://localhost/document/v1/space/music/docid/one", PATCH);
        assertSameJson("{" +
                       "  \"pathId\": \"/document/v1/space/music/docid/one\"," +
                       "  \"message\": \"'PATCH' not allowed at '/document/v1/space/music/docid/one'. Allowed methods are: GET, POST, PUT, DELETE\"" +
                       "}", response.readAll());
        assertEquals(405, response.getStatus());

        // Request response does not arrive before timeout has passed.
        AtomicReference<ResponseHandler> handler = new AtomicReference<>();
        access.session.expect((id, parameters) -> {
            handler.set(parameters.responseHandler().get());
            return new Result();
        });
        try {
            var response4 = driver.sendRequest("http://localhost/document/v1/space/music/docid/one?timeout=1ms");
            assertSameJson("{" +
                           "  \"pathId\": \"/document/v1/space/music/docid/one\"," +
                           "  \"message\": \"Timeout after 1ms\"" +
                           "}", response4.readAll());
            assertEquals(504, response4.getStatus());
        }
        finally {
            if (handler.get() != null)                          // Timeout may have occurred before dispatch, or ...
                handler.get().handleResponse(new Response(0));  // response may eventually arrive, but too late.
        }

        assertEquals(3, metric.metrics().get("httpapi_succeeded").get(Map.of()), 0);
        assertEquals(1, metric.metrics().get("httpapi_condition_not_met").get(Map.of()), 0);
        assertEquals(1, metric.metrics().get("httpapi_not_found").get(Map.of()), 0);
        assertEquals(1, metric.metrics().get("httpapi_failed").get(Map.of()), 0);
        driver.close();
    }

    private void doTestVisitRequestWithParams(String httpReqParams, Consumer<VisitorParameters> paramChecker) {
        try (var driver = new RequestHandlerTestDriver(handler)) {
            access.expect(parameters -> {
                paramChecker.accept(parameters);
                parameters.getControlHandler().onDone(VisitorControlHandler.CompletionCode.SUCCESS, "great success");
            });
            var response = driver.sendRequest("http://localhost/document/v1/?cluster=content&%s".formatted(httpReqParams));
            assertSameJson("""
                            {
                              "pathId": "/document/v1/",
                              "documents": [ ],
                              "documentCount": 0
                            }""",
                    response.readAll());
            assertEquals(200, response.getStatus());
        }
    }

    @Test
    public void visit_timestamp_ranges_can_be_open_in_both_ends() {
        // Only specifying fromTimestamp; visit up to current time
        doTestVisitRequestWithParams("fromTimestamp=1234", (params) -> {
            assertEquals(params.getFromTimestamp(), 1234);
            assertEquals(params.getToTimestamp(), 0); // Means "current wall clock time" when it hits storage
        });

        // Only specifying toTimestamp; visit all docs up to this time point
        doTestVisitRequestWithParams("toTimestamp=2345", (params) -> {
            assertEquals(params.getFromTimestamp(), 0); // The dawn of time(tm)
            assertEquals(params.getToTimestamp(), 2345);
        });
    }

    @Test
    public void testThroughput() throws InterruptedException {
        DocumentOperationExecutorConfig executorConfig = new DocumentOperationExecutorConfig.Builder().build();
        handler = new DocumentV1ApiHandler(clock, Duration.ofMillis(1), metric, metrics, access, docConfig,
                                           executorConfig, clusterConfig, bucketConfig);

        int writers = 4;
        int queueFill = executorConfig.maxThrottled() - writers;
        RequestHandlerTestDriver driver = new RequestHandlerTestDriver(handler);
        ScheduledExecutorService writer = Executors.newScheduledThreadPool(writers);
        ScheduledExecutorService reader = Executors.newScheduledThreadPool(1);
        ScheduledExecutorService replier = Executors.newScheduledThreadPool(writers);
        BlockingQueue<RequestHandlerTestDriver.MockResponseHandler> responses = new LinkedBlockingQueue<>();

        Response success = new Response(0, null, Response.Outcome.SUCCESS);
        int docs = 1 << 14;
        assertTrue(docs >= writers);
        AtomicReference<com.yahoo.jdisc.Response> failed = new AtomicReference<>();

        CountDownLatch latch = new CountDownLatch(docs);
        reader.execute(() -> {
            while ( ! reader.isShutdown()) {
                try {
                    var response = responses.take();
                    response.awaitResponse().readAll();
                    if (response.getStatus() != 200)
                        failed.set(response.getResponse());
                    latch.countDown();
                }
                catch (InterruptedException e) { break; }
            }
        });

        // Fill the handler resend queue.
        long startNanos = System.nanoTime();
        CountDownLatch setup = new CountDownLatch(queueFill);
        access.session.expect((id, parameters) -> {
            setup.countDown();
            return new Result(Result.ResultType.TRANSIENT_ERROR, Result.toError(Result.ResultType.TRANSIENT_ERROR));
        });
        for (int i = 0; i < queueFill; i++) {
            int j = i;
            writer.execute(() -> {
                responses.add(driver.sendRequest("http://localhost/document/v1/ns/music/docid/" + j,
                                                 POST,
                                                 "{ \"fields\": { \"artist\": \"Sigrid\" } }"));
            });
        }
        setup.await();

        // Let "messagebus" start accepting messages.
        access.session.expect((id, parameters) -> {
            replier.schedule(() -> parameters.responseHandler().get().handleResponse(success), 10, TimeUnit.MILLISECONDS);
            return new Result(0);
        });
        // Send the rest of the documents. Rely on resender to empty queue of throttled operations.
        for (int i = queueFill; i < docs; i++) {
            int j = i;
            writer.execute(() -> {
                responses.add(driver.sendRequest("http://localhost/document/v1/ns/music/docid/" + j,
                                                 POST,
                                                 "{ \"fields\": { \"artist\": \"Sigrid\" } }"));
            });
        }
        latch.await();
        System.err.println(docs + " requests in " + (System.nanoTime() - startNanos) * 1e-9 + " seconds");

        assertNull(failed.get());
        driver.close();
    }


    static class MockDocumentAccess extends DocumentAccess {

        private final AtomicReference<Consumer<VisitorParameters>> expectations = new AtomicReference<>();
        private final Set<AckToken> outstanding = new CopyOnWriteArraySet<>();
        private final MockAsyncSession session = new MockAsyncSession();
        private Trace visitorTrace;

        MockDocumentAccess(DocumentmanagerConfig config) {
            super(new DocumentAccessParams().setDocumentmanagerConfig(config));
        }

        @Override
        public SyncSession createSyncSession(SyncParameters parameters) {
            throw new AssertionError("Not used");
        }

        @Override
        public AsyncSession createAsyncSession(AsyncParameters parameters) {
            return session;
        }

        @Override
        public VisitorSession createVisitorSession(VisitorParameters parameters) {
            VisitorSession visitorSession = new VisitorSession() {
                {
                    parameters.getControlHandler().setSession(this);
                    if (parameters.getLocalDataHandler() != null)
                        parameters.getLocalDataHandler().setSession(this);
                }
                @Override public boolean isDone() { return false; }
                @Override public ProgressToken getProgress() { return null; }
                @Override public Trace getTrace() { return visitorTrace; }
                @Override public boolean waitUntilDone(long timeoutMs) { return false; }
                @Override public void ack(AckToken token) { assertTrue(outstanding.remove(token)); }
                @Override public void abort() { }
                @Override public VisitorResponse getNext() { return null; }
                @Override public VisitorResponse getNext(int timeoutMilliseconds) { return null; }
                @Override public void destroy() { assertEquals(Set.of(), outstanding); }
            };
            expectations.get().accept(parameters);
            return visitorSession;
        }

        @Override
        public VisitorDestinationSession createVisitorDestinationSession(VisitorDestinationParameters parameters) {
            throw new AssertionError("Not used");
        }

        @Override
        public SubscriptionSession createSubscription(SubscriptionParameters parameters) {
            throw new AssertionError("Not used");
        }

        @Override
        public SubscriptionSession openSubscription(SubscriptionParameters parameters) {
            throw new AssertionError("Not used");
        }

        public void expect(Consumer<VisitorParameters> expectations) {
            this.expectations.set(expectations);
        }

        public void expect(Collection<AckToken> tokens) {
            outstanding.addAll(tokens);
        }

    }


    static class MockAsyncSession implements AsyncSession {

        private final AtomicReference<BiFunction<Object, DocumentOperationParameters, Result>> expectations = new AtomicReference<>();

        @Override
        public Result put(Document document) {
            throw new AssertionError("Not used");
        }

        @Override
        public Result put(DocumentPut documentPut, DocumentOperationParameters parameters) {
            return expectations.get().apply(documentPut, parameters);
        }

        @Override
        public Result get(DocumentId id) {
            throw new AssertionError("Not used");
        }

        @Override
        public Result get(DocumentId id, DocumentOperationParameters parameters) {
            return expectations.get().apply(id, parameters);
        }

        @Override
        public Result remove(DocumentId id) {
            throw new AssertionError("Not used");
        }

        @Override
        public Result remove(DocumentRemove remove, DocumentOperationParameters parameters) {
            return expectations.get().apply(remove, parameters);
        }

        @Override
        public Result update(DocumentUpdate update) {
            throw new AssertionError("Not used");
        }

        @Override
        public Result update(DocumentUpdate update, DocumentOperationParameters parameters) {
            return expectations.get().apply(update, parameters);
        }

        @Override
        public double getCurrentWindowSize() {
            throw new AssertionError("Not used");
        }

        public void expect(BiFunction<Object, DocumentOperationParameters, Result> expectations) {
            this.expectations.set(expectations);
        }

        @Override
        public Response getNext() {
            throw new AssertionError("Not used");
        }

        @Override
        public Response getNext(int timeoutMilliseconds) {
            throw new AssertionError("Not used");
        }

        @Override
        public void destroy() { }

    }

    static void assertSameJson(String expected, String actual) {
        ByteArrayOutputStream expectedPretty = new ByteArrayOutputStream();
        ByteArrayOutputStream actualPretty = new ByteArrayOutputStream();
        JsonFormat formatter = new JsonFormat(false);
        try {
            formatter.encode(actualPretty, SlimeUtils.jsonToSlimeOrThrow(actual));
            formatter.encode(expectedPretty, SlimeUtils.jsonToSlimeOrThrow(expected));
        }
        catch (IOException e) {
            throw new UncheckedIOException(e);
        }
        assertEquals(expectedPretty.toString(UTF_8), actualPretty.toString(UTF_8));
    }

}