diff options
author | Martin Polden <mpolden@mpolden.no> | 2021-06-27 14:48:23 +0200 |
---|---|---|
committer | Martin Polden <mpolden@mpolden.no> | 2021-06-27 14:51:24 +0200 |
commit | bead191587f6b4a941d91c56580540233376ddb9 (patch) | |
tree | 829184adea07fc03d54c3606c9bd77100797e67d | |
parent | 328d70d166e002b32ee9c59801aa57eece14e465 (diff) |
record: Stop using unmaintained tealeg/xlsx module
-rw-r--r-- | go.mod | 2 | ||||
-rw-r--r-- | go.sum | 44 | ||||
-rw-r--r-- | record/dnb/dnb.go | 36 | ||||
-rw-r--r-- | record/dnb/dnb_test.go | 6 | ||||
-rw-r--r-- | record/norwegian/norwegian.go | 31 |
5 files changed, 71 insertions, 48 deletions
@@ -3,12 +3,12 @@ module github.com/mpolden/journal go 1.13 require ( + github.com/360EntSecGroup-Skylar/excelize/v2 v2.4.0 github.com/BurntSushi/toml v0.3.1 github.com/jessevdk/go-flags v1.4.0 github.com/jmoiron/sqlx v1.3.4 github.com/mattn/go-sqlite3 v1.14.6 github.com/olekukonko/tablewriter v0.0.4 - github.com/tealeg/xlsx v1.0.5 golang.org/x/lint v0.0.0-20201208152925-83fdc39ff7b5 honnef.co/go/tools v0.1.2 ) @@ -1,5 +1,9 @@ +github.com/360EntSecGroup-Skylar/excelize/v2 v2.4.0 h1:X+2CWGf5W1tm2+W7Y/LLrAPLFSNlHATnqDudGoIzaxY= +github.com/360EntSecGroup-Skylar/excelize/v2 v2.4.0/go.mod h1:p9lGPoVX3HYEbFRfjgrPWaaKsHe/2u4EM9DB/qoctgU= github.com/BurntSushi/toml v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ= github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU= +github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8= +github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= github.com/go-sql-driver/mysql v1.5.0 h1:ozyZYNQW3x3HtqT1jira07DN2PArx2v7/mN66gGcHOs= github.com/go-sql-driver/mysql v1.5.0/go.mod h1:DCzpHaOWr8IXmIStZouvnhqoel9Qv2LBy8hT2VhHyBg= github.com/jessevdk/go-flags v1.4.0 h1:4IU2WS7AumrZ/40jfhf4QVDMsQwqA7VEHozFRrGARJA= @@ -7,25 +11,35 @@ github.com/jessevdk/go-flags v1.4.0/go.mod h1:4FA24M0QyGHXBuZZK/XkWh8h0e1EYbRYJS github.com/jmoiron/sqlx v1.3.4 h1:wv+0IJZfL5z0uZoUjlpKgHkgaFSYD+r9CfrXjEXsO7w= github.com/jmoiron/sqlx v1.3.4/go.mod h1:2BljVx/86SuTyjE+aPYlHCTNvZrnJXghYGpNiXLBMCQ= github.com/kisielk/gotool v1.0.0/go.mod h1:XhKaO+MFFWcvkIS/tQcRk01m1F5IRFswLeQ+oQHNcck= -github.com/kr/pretty v0.1.0 h1:L/CwN0zerZDmRFUapSPitk6f+Q3+0za1rQkzVuMiMFI= -github.com/kr/pretty v0.1.0/go.mod h1:dAy3ld7l9f0ibDNOQOHHMYYIIbhfbHSm3C4ZsoJORNo= -github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ= -github.com/kr/text v0.1.0 h1:45sCR5RtlFHMR4UwH9sdQ5TC8v0qDQCHnXt+kaKSTVE= -github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI= github.com/lib/pq v1.2.0 h1:LXpIM/LZ5xGFhOpXAQUIMM1HdyqzVYM13zNdjCEEcA0= github.com/lib/pq v1.2.0/go.mod h1:5WUZQaWbwv1U+lTReE5YruASi9Al49XbQIvNi/34Woo= github.com/mattn/go-runewidth v0.0.7 h1:Ei8KR0497xHyKJPAv59M1dkC+rOZCMBJ+t3fZ+twI54= github.com/mattn/go-runewidth v0.0.7/go.mod h1:H031xJmbD/WCDINGzjvQ9THkh0rPKHF+m2gUSrubnMI= github.com/mattn/go-sqlite3 v1.14.6 h1:dNPt6NO46WmLVt2DLNpwczCmdV5boIZ6g/tlDrlRUbg= github.com/mattn/go-sqlite3 v1.14.6/go.mod h1:NyWgC/yNuGj7Q9rpYnZvas74GogHl5/Z4A/KQRfk6bU= +github.com/mohae/deepcopy v0.0.0-20170929034955-c48cc78d4826 h1:RWengNIwukTxcDr9M+97sNutRR1RKhG96O6jWumTTnw= +github.com/mohae/deepcopy v0.0.0-20170929034955-c48cc78d4826/go.mod h1:TaXosZuwdSHYgviHp1DAtfrULt5eUgsSMsZf+YrPgl8= github.com/olekukonko/tablewriter v0.0.4 h1:vHD/YYe1Wolo78koG299f7V/VAS08c6IpCLn+Ejf/w8= github.com/olekukonko/tablewriter v0.0.4/go.mod h1:zq6QwlOf5SlnkVbMSr5EoBv3636FWnp+qbPhuoO21uA= -github.com/tealeg/xlsx v1.0.5 h1:+f8oFmvY8Gw1iUXzPk+kz+4GpbDZPK1FhPiQRd+ypgE= -github.com/tealeg/xlsx v1.0.5/go.mod h1:btRS8dz54TDnvKNosuAqxrM1QgN1udgk9O34bDCnORM= +github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= +github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= +github.com/richardlehane/mscfb v1.0.3 h1:rD8TBkYWkObWO0oLDFCbwMeZ4KoalxQy+QgniCj3nKI= +github.com/richardlehane/mscfb v1.0.3/go.mod h1:YzVpcZg9czvAuhk9T+a3avCpcFPMUWm7gK3DypaEsUk= +github.com/richardlehane/msoleps v1.0.1 h1:RfrALnSNXzmXLbGct/P2b4xkFz4e8Gmj/0Vj9M9xC1o= +github.com/richardlehane/msoleps v1.0.1/go.mod h1:BWev5JBpU9Ko2WAgmZEuiz4/u3ZYTKbjLycmwiWUfWg= +github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME= +github.com/stretchr/testify v1.6.1 h1:hDPOHmpOpP40lSULcqw7IrRb/u7w6RpDC9399XyoNd0= +github.com/stretchr/testify v1.6.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg= +github.com/xuri/efp v0.0.0-20210322160811-ab561f5b45e3 h1:EpI0bqf/eX9SdZDwlMmahKM+CDBgNbsXMhsN28XrM8o= +github.com/xuri/efp v0.0.0-20210322160811-ab561f5b45e3/go.mod h1:ybY/Jr0T0GTCnYjKqmdwxyxn2BQf2RcQIIvex5QldPI= github.com/yuin/goldmark v1.2.1/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74= golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w= golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI= golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= +golang.org/x/crypto v0.0.0-20210415154028-4f45737414dc h1:+q90ECDSAQirdykUN6sPEiBXBsp8Csjcca8Oy7bgLTA= +golang.org/x/crypto v0.0.0-20210415154028-4f45737414dc/go.mod h1:T9bdIzuCu7OtxOm1hfPfRQxPLYneinmdGuTeoZ9dtd4= +golang.org/x/image v0.0.0-20210220032944-ac19c3e999fb h1:fqpd0EBDzlHRCjiphRR5Zo/RSWWQlWv34418dnEixWk= +golang.org/x/image v0.0.0-20210220032944-ac19c3e999fb/go.mod h1:FeLwcggjj3mMvU+oOTbSwawSJRM1uh48EjtB4UJZlP0= golang.org/x/lint v0.0.0-20201208152925-83fdc39ff7b5 h1:2M3HP5CCK1Si9FQhwnzYhXdG6DXeebvUHFpre8QvbyI= golang.org/x/lint v0.0.0-20201208152925-83fdc39ff7b5/go.mod h1:3xt1FjdF8hUf6vQPIChWIBhFzV8gjjsPE/fR3IyQdNY= golang.org/x/mod v0.1.1-0.20191105210325-c90efee705ee/go.mod h1:QqPTAvyqsEbceGzBzNggFXnrqF1CaUcvgkdR5Ot7KZg= @@ -34,15 +48,23 @@ golang.org/x/mod v0.3.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA= golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg= golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s= golang.org/x/net v0.0.0-20201021035429-f5854403a974/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU= +golang.org/x/net v0.0.0-20210226172049-e18ecbb05110/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg= +golang.org/x/net v0.0.0-20210415231046-e915ea6b2b7d h1:BgJvlyh+UqCUaPlscHJ+PN8GcpfrFdr7NHjd1JL0+Gs= +golang.org/x/net v0.0.0-20210415231046-e915ea6b2b7d/go.mod h1:9tjilg8BloeKEkVJvy7fQ90B1CfIiPueXVOjqfkSzI8= golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= -golang.org/x/sys v0.0.0-20210119212857-b64e53b001e4 h1:myAQVi0cGEoqQVR5POX+8RR2mrocKqNN1hmeMqhX27k= +golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20210119212857-b64e53b001e4/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20210330210617-4fbd30eecc44 h1:Bli41pIlzTzf3KEY06n+xnzK/BESIg2ze4Pgfh/aI8c= +golang.org/x/sys v0.0.0-20210330210617-4fbd30eecc44/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= +golang.org/x/text v0.3.6 h1:aRYxNxv6iGQlyVaZmk6ZgYEDa+Jg18DxebPSrd6bg1M= +golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= golang.org/x/tools v0.0.0-20191119224855-298f0cb1881e/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo= golang.org/x/tools v0.0.0-20200130002326-2f3ba24bd6e7/go.mod h1:TB2adYChydJhpapKDTa4BR/hXlZSLoq2Wpct/0txZ28= @@ -52,7 +74,9 @@ golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8T golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE= golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= -gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15 h1:YR8cESwS4TdDjEe65xsg0ogRM/Nc3DYOhEAlW+xobZo= -gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= +gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM= +gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= +gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c h1:dUUwHk2QECo/6vqA44rthZ8ie2QXMNeKRTHCNY2nXvo= +gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= honnef.co/go/tools v0.1.2 h1:SMdYLJl312RXuxXziCCHhRsp/tvct9cGKey0yv95tZM= honnef.co/go/tools v0.1.2/go.mod h1:NgwopIslSNH47DimFoV78dnkksY2EFtX0ajyb3K/las= diff --git a/record/dnb/dnb.go b/record/dnb/dnb.go index 4386d0f..12ad5d2 100644 --- a/record/dnb/dnb.go +++ b/record/dnb/dnb.go @@ -3,12 +3,12 @@ package dnb import ( "fmt" "io" - "io/ioutil" "strconv" "strings" + "time" + "github.com/360EntSecGroup-Skylar/excelize/v2" "github.com/mpolden/journal/record" - "github.com/tealeg/xlsx" ) const ( @@ -51,45 +51,45 @@ func (r *Reader) parseAmount(s string) (int64, error) { } func (r *Reader) Read() ([]record.Record, error) { - data, err := ioutil.ReadAll(r.rd) + data, err := excelize.OpenReader(r.rd) if err != nil { return nil, err } - f, err := xlsx.OpenBinary(data) + if len(data.GetSheetList()) == 0 { + return nil, fmt.Errorf("xlsx contains 0 sheets") + } + firstSheet := data.GetSheetName(0) + rows, err := data.GetRows(firstSheet) if err != nil { return nil, err } - if len(f.Sheets) == 0 { - return nil, fmt.Errorf("xlsx contains 0 sheets") - } var rs []record.Record - for _, row := range f.Sheets[0].Rows { - cells := row.Cells + for _, cells := range rows { if len(cells) < 6 { continue } - if cells[0].String() == firstHeaderCell { // Header row + if cells[0] == firstHeaderCell { // Header row continue } - if cells[0].String() == "" { // Missing date + if cells[0] == "" { // Missing date continue } - time, err := cells[0].GetTime(false) + time, err := time.Parse(`"02".01."2006"`, cells[0]) if err != nil { - return nil, err + return nil, fmt.Errorf("invalid date: %q: %w", cells[0], err) } - amountIn, err := r.parseAmount(cells[4].String()) + amountIn, err := r.parseAmount(cells[4]) if err != nil { - return nil, err + return nil, fmt.Errorf("invalid amount: %q: %w", cells[4], err) } - amountOut, err := r.parseAmount(cells[5].String()) + amountOut, err := r.parseAmount(cells[5]) if err != nil { - return nil, err + return nil, fmt.Errorf("invalid amount: %q: %w", cells[5], err) } amount := amountIn - amountOut r := record.Record{ Time: time, - Text: cells[1].String(), + Text: cells[1], Amount: amount, } rs = append(rs, r) diff --git a/record/dnb/dnb_test.go b/record/dnb/dnb_test.go index ae2983e..f5294ee 100644 --- a/record/dnb/dnb_test.go +++ b/record/dnb/dnb_test.go @@ -30,9 +30,9 @@ func TestRead(t *testing.T) { text string amount int64 }{ - {time.Date(2020, 6, 25, 2, 0, 0, 209, time.UTC), "Transaction 1", -119990}, - {time.Date(2020, 6, 26, 2, 0, 0, 209, time.UTC), "Transaction 2", -59995}, - {time.Date(2020, 6, 27, 2, 0, 0, 209, time.UTC), "Transaction 3", 70000}, + {time.Date(2020, 6, 25, 0, 0, 0, 0, time.UTC), "Transaction 1", -119990}, + {time.Date(2020, 6, 26, 0, 0, 0, 0, time.UTC), "Transaction 2", -59995}, + {time.Date(2020, 6, 27, 0, 0, 0, 0, time.UTC), "Transaction 3", 70000}, } if len(rs) != len(tests) { t.Fatalf("want %d records, got %d", len(tests), len(rs)) diff --git a/record/norwegian/norwegian.go b/record/norwegian/norwegian.go index 93b9566..935784a 100644 --- a/record/norwegian/norwegian.go +++ b/record/norwegian/norwegian.go @@ -3,13 +3,12 @@ package norwegian import ( "fmt" "io" - "io/ioutil" "strconv" "strings" "time" + "github.com/360EntSecGroup-Skylar/excelize/v2" "github.com/mpolden/journal/record" - "github.com/tealeg/xlsx" ) const ( @@ -49,40 +48,40 @@ func (r *Reader) parseAmount(s string) (int64, error) { } func (r *Reader) Read() ([]record.Record, error) { - data, err := ioutil.ReadAll(r.rd) + data, err := excelize.OpenReader(r.rd) if err != nil { return nil, err } - f, err := xlsx.OpenBinary(data) + if len(data.GetSheetList()) == 0 { + return nil, fmt.Errorf("xlsx contains 0 sheets") + } + firstSheet := data.GetSheetName(0) + rows, err := data.GetRows(firstSheet) if err != nil { return nil, err } - if len(f.Sheets) == 0 { - return nil, fmt.Errorf("xlsx contains 0 sheets") - } var rs []record.Record - for _, row := range f.Sheets[0].Rows { - cells := row.Cells + for _, cells := range rows { if len(cells) < 7 { continue } - if cells[0].String() == firstHeaderCell { // Header row + if cells[0] == firstHeaderCell { // Header row continue } - if cells[0].String() == "" { // Empty row + if cells[0] == "" { // Empty row continue } - time, err := time.Parse("01-02-06", cells[0].String()) + time, err := time.Parse("01-02-06", cells[0]) if err != nil { - return nil, fmt.Errorf("invalid date: %q: %w", cells[0].String(), err) + return nil, fmt.Errorf("invalid date: %q: %w", cells[0], err) } - amount, err := r.parseAmount(cells[6].String()) + amount, err := r.parseAmount(cells[6]) if err != nil { - return nil, fmt.Errorf("invalid amount: %q: %w", cells[6].String(), err) + return nil, fmt.Errorf("invalid amount: %q: %w", cells[6], err) } t := record.Record{ Time: time, - Text: cells[1].String(), + Text: cells[1], Amount: amount, } rs = append(rs, t) |